1739596 - Port Bug 1737673 to Thunderbird - Formalize the 'variant' subsystem in test transforms

Status: RESOLVED WORKSFORME

(Thunderbird :: Upstream Synchronization, task)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1737673 +++

Bug 1737673 have busted comm-central.

My quick attempt to just copy over the variants.yml file did not help (https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=16d71bed1a0645364f9c07e397939660bfda9085)

Comment 1

[Magnus Melin [:mkmelin]]

Hmm, or is it something else. At least local builds fails due to missing vairant.yml

On CI: ERROR - /builds/worker/checkouts/gecko/comm/mailnews/base/src/nsMsgI18N.cpp:244:41: error: no viable overloaded '='

Comment 2

[Magnus Melin [:mkmelin]]

The local problem may be bug 1739520

Comment 3

[Magnus Melin [:mkmelin]]

The build issue should be from bug 1603127. Possible fix on try

Comment 4

[Magnus Melin [:mkmelin]]

My try build for bug 1603127 built fine on try, but not on comm-central

• https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=915a3b56c7149c62b411b84d05684543c6c52436
• https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=fKTZU6doRw6pmGunI1IYoA.0&revision=b2e956b4671ea2f84b29db9b0a3194c48ad538e0

Ah - bug 1603127 backed out from mozilla-central.

Maybe bug 1739520 is all that's left.

Comment 5

[Magnus Melin [:mkmelin]]

Looks like all the problems are taken care of now.

Comment 6

[Intermittent Failures Robot]

20 failures in 510 pushes (0.039 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 20

Platform and build breakdown:

• linux64-shippable: 1
  • opt: 1
• windows2012-64: 3
  • debug: 1
  • asan: 1
  • opt: 1
• osx-cross: 2
  • debug: 1
  • opt: 1
• osx-aarch64-shippable: 1
  • opt: 1
• linux32: 2
  • opt: 1
  • debug: 1
• linux32-shippable: 1
  • opt: 1
• windows2012-32-shippable: 1
  • opt: 1
• linux64: 4
  • opt: 1
  • tsan: 1
  • debug: 1
  • asan: 1
• windows2012-64-shippable: 1
  • opt: 1
• linux64-aarch64: 1
  • opt: 1
• windows2012-32: 2
  • opt: 1
  • debug: 1
• osx-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1739596&startday=2021-11-05&endday=2021-11-05&tree=all

Comment 7

[Intermittent Failures Robot]

20 failures in 3030 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 20

Platform and build breakdown:

• linux64-shippable: 1
  • opt: 1
• windows2012-64: 3
  • debug: 1
  • asan: 1
  • opt: 1
• osx-cross: 2
  • debug: 1
  • opt: 1
• osx-aarch64-shippable: 1
  • opt: 1
• linux32: 2
  • opt: 1
  • debug: 1
• linux32-shippable: 1
  • opt: 1
• windows2012-32-shippable: 1
  • opt: 1
• linux64: 4
  • opt: 1
  • tsan: 1
  • debug: 1
  • asan: 1
• windows2012-64-shippable: 1
  • opt: 1
• linux64-aarch64: 1
  • opt: 1
• windows2012-32: 2
  • opt: 1
  • debug: 1
• osx-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1739596&startday=2021-11-01&endday=2021-11-07&tree=all

Comment 8

[Rob Lemley [:rjl]]

Currently Thunderbird doesn't make use of variants in any of the tests. Looking at the Firefox variants.yml file, its being used to switch out webrender and fission and such.

A possible use case for variants is the C++ -> JS protocol work.

Comment 9

[Rob Lemley [:rjl]]

Currently Thunderbird doesn't make use of variants in any of the tests. Looking at the Firefox variants.yml file, its being used to switch out webrender and fission and such.

A possible use case for variants is the C++ -> JS protocol work.