1739977 - Update check in about window spins forever when it gets aborted

Status: NEW

(Toolkit :: Application Update, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko/20100101 Firefox/95.0 ID:20211031213949

I'm usually not shutting down and restarting Firefox unless there is an update in the queue. Today I noticed that by surprise I'm still on a build from Oct 31st. I might have gotten an update notification, but clicked it away.

Forcing an update check this morning causes the spinner in the about window to run forever. Checking the DevTools browser console shows the following:

11:44:25.743 AUS:SVC Checker: checkForUpdates, force: true
11:44:25.743 AUS:SVC UpdateService.canUsuallyCheckForUpdates - able to check for updates
11:44:25.743 AUS:SVC UpdateService.canCheckForUpdates - able to check for updates
11:44:25.746 AUS:SVC Checker:getUpdateURL - update URL: https://aus5.mozilla.org/update/6/Firefox/95.0a1/20211031213949/Darwin_x86_64-gcc3/en-US/nightly/Darwin%2020.6.0/ISET:SSE4_2,MEM:16384/default/default/update.xml?force=1
11:44:25.746 AUS:SVC Checker: checkForUpdates: check request already active, aborting

So what happens here is that we abort the check because one other is active, but we do not reset the content in the about window. While the hamburger menu clearly shows a green dot, means that an update is available, it's not possible for me to start the upgrade via the about window.

Comment 1

[Mark Banner (:standard8)]

I know what's happening here, I have a fix, just working on a test case.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1739977 - If an update via the about dialog is cancelled due to staying on a page, ensure the dialog is reset to the apply state. r?bytesized

Comment 3

[Phabricator Automation]

Comment on attachment 9277292 [details]
Bug 1739977 - If an update via the about dialog is cancelled due to staying on a page, ensure the dialog is reset to the apply state. r?bytesized

Revision D146805 was moved to bug 1607498. Setting attachment 9277292 [details] to obsolete.

Comment 4

[Mark Banner (:standard8)]

Sorry, wrong bug.

Comment 5

[Phabricator Automation]

Comment on attachment 9277292 [details]
Bug 1739977 - If an update via the about dialog is cancelled due to staying on a page, ensure the dialog is reset to the apply state. r?bytesized

Revision D146805 was moved to bug 1607498. Setting attachment 9277292 [details] to obsolete.