Cleanup code for auto launching downloads
Categories
(Firefox :: Downloads Panel, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: mtigley, Assigned: mtigley)
References
Details
Attachments
(1 file, 1 obsolete file)
This is a task for making the code easier to follow when a download is set to launch when finished. Currently, it's not entirely inituitive where setup to download the file and then launch it happens and this should help address some of that confusion. There's a few things we should do:
-
Rename
LaunchWithApplicationtoSetupDownloadToLaunch. See https://phabricator.services.mozilla.com/D130411#inline-716970 for some background on this. To sum it up,LaunchWithApplicationdoesn't actually handle opening the file itself. That happens here. -
Move opening local files out of
LaunchWithApplicationinto its own method. -
Update callers of
launchWithApplicationto call the new method to handle opening local files
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f718538b94c Rename LaunchWithApplication to SetDownloadToLaunch. r=Gijs
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
||
Comment 4•2 years ago
|
||
Depends on D135980
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9259067 [details]
Bug 1740142 - Support screen.orientation.lock('any') on GeckoView backend. r=#geckoview-reviewers
Revision D135981 was moved to bug 1750142. Setting attachment 9259067 [details] to obsolete.
Description
•