1745066 - Opening of attachments broken by bug 1740142

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect, P1)

Description

[Geoff Lankow (:darktrojan)]

Bug 1740142 renamed LaunchWithApplication to SetDownloadToLaunch, and so our attachment opening code is broken. Again.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1745066 - Port bug 1740142 - Rename LaunchWithApplication to SetDownloadToLaunch. r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5fe5bcaa3a45
Port bug 1740142 - Rename LaunchWithApplication to SetDownloadToLaunch. r=aleca

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9254421 [details]
Bug 1745066 - Port bug 1740142 - Rename LaunchWithApplication to SetDownloadToLaunch. r=aleca

[Approval Request Comment]
Regression caused by (bug #): bug 1740142
User impact if declined: can't open attachments, again
Testing completed (on c-c, etc.): landed today
Risk to taking this patch (and alternatives if risky): no risk, but should get manually verified before release

We should add "doing various things with attachments" to the smoke test.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9254421 [details]
Bug 1745066 - Port bug 1740142 - Rename LaunchWithApplication to SetDownloadToLaunch. r=aleca

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 96.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/8cfd18f565f2