Closed Bug 1740205 Opened 3 years ago Closed 2 years ago

New wpt failures in /css/css-sizing/aspect-ratio/ [flex-aspect-ratio-002.html, flex-aspect-ratio-004.html]

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: wpt-sync, Assigned: boris)

References

(Blocks 2 open bugs,
URL
)

Details

(Whiteboard: [wpt])

Syncing wpt PR 31528 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

/css/css-sizing/aspect-ratio/flex-aspect-ratio-002.html: FAIL

New Tests That Don't Pass

/css/css-sizing/aspect-ratio/flex-aspect-ratio-004.html: FAIL (Chrome: FAIL, Safari: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1739718 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Severity: -- → S3
Blocks: aspect-ratio

Note, these two tests are included in the compat2021 set (in the list at https://github.com/Ecosystem-Infra/wpt-results-analysis/blob/master/compat-2021/aspect-ratio-tests.txt ). Adding metabug association.

Blocks: compat2021
Assignee: nobody → boris.chiou

There is a spec issue related to this bug, and it will change content-size suggestion to min-intrinsic instead of min-content:
https://github.com/w3c/csswg-drafts/issues/6794#issuecomment-1063323692

This means the content-size suggestion doesn't honor aspect-ratio any more.

So for there two test cases:

  1. it is non-replaced, and is non-empty
  2. min-size is auto

So we have to avoid overflow in these two test cases. That means we may have to update the tests once this spec words get updated. (i.e. Firefox's current behavior should be correct.)

Looks like we pass these tests now. wpt.fyi shows us with "pass" status for both of these:
https://wpt.fyi/results/css/css-sizing/aspect-ratio/flex-aspect-ratio-002.html
https://wpt.fyi/results/css/css-sizing/aspect-ratio/flex-aspect-ratio-004.html

And I don't see any .ini files for these tests in-tree.

-->WORKSFORME.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.