1740345 - Land final strings for Firefox Suggest preferences redesign

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

When user testing is done and strings for the preferences UI are finalized, we'll need to land them and uplift to 95/94.

Comment 1

[Drew Willcoxon :adw]

And to be clear, these are strings in firefoxSuggest.ftl and they are not exposed to localizers.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1740345 - Land final strings for Firefox Suggest preferences redesign.

This updates the non-localized strings that appear in the Firefox Suggest
preferences UI with the final approved strings.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d4b4f5e09e2
Land final strings for Firefox Suggest preferences redesign. r=harry

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9d4b4f5e09e2

Comment 5

[Drew Willcoxon :adw]

STR for QA

Enroll in offline or online, open about:preferences#privacy, and verify the following strings are used in the Firefox Suggest section.

The toggle label and description strings are:

Toggle 1 label: Suggestions from the web
Description: Get suggestions from Firefox related to your search.

Toggle 2 label: Suggestions from sponsors
Description: Support the development of Firefox with occasional sponsored suggestions.
[Note: This will say Nightly instead of Firefox on Nightly]

Toggle 3 label: Improve the Firefox Suggest experience
Description: Help create a richer search experience by allowing Mozilla to process your search queries. Learn more

The info box under the toggles has 7 possible strings depending on the combination of toggles:

Toggle 1: On
Toggle 2: On
Toggle 3: On
Based on your selection, you'll receive suggestions from the web, including sponsored sites. We will process your search query data to develop the Firefox Suggest feature.

Toggle 1: On
Toggle 2: On
Toggle 3: Off
Based on your selection, you'll receive suggestions from the web, including sponsored sites. We won't process your search query data.

Toggle 1: On
Toggle 2: Off
Toggle 3: On
Based on your selection, you'll receive suggestions from the web, but no sponsored sites. We will process your search query data to develop the Firefox Suggest feature.

Toggle 1: On
Toggle 2: Off
Toggle 3: Off
Based on your selection, you'll receive suggestions from the web, but no sponsored sites. We won't process your search query data.

Toggle 1: Off
Toggle 2: On
Toggle 3: On
Based on your selection, you'll receive sponsored suggestions. We will process your search query data to develop the Firefox Suggest feature.

Toggle 1: Off
Toggle 2: On
Toggle 3: Off
Based on your selection, you'll receive sponsored suggestions. We won't process your search query data.

Toggle 1: Off
Toggle 2: Off
Toggle 3: On
Based on your selection, you won't receive suggestions from the web or sponsored sites. We will process your search query data to develop the Firefox Suggest feature.

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 9250462 [details]
Bug 1740345 - Land final strings for Firefox Suggest preferences redesign.

Beta/Release Uplift Approval Request

• User impact if declined: We need this for the Firefox Suggest preferences redesign targeting 95/94.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 5
• List of other uplifts needed: Please see uplift spreadsheet: https://docs.google.com/spreadsheets/d/1LavihS-VOPFYEyum7mrx6FKXmuQeHi9xQHfGNSxjnoY/edit?usp=sharing
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a en-US strings-only patch, and the strings are not exposed to localizers and do not need localization.
• String changes made/needed:

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this bug on the latest Nightly 96.0a1 build (Build ID: 20211115215316) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20 x64.

• The strings are correctly displayed as described in comment 5 for each scenario.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9250462 [details]
Bug 1740345 - Land final strings for Firefox Suggest preferences redesign.

Approved for 95 beta 8, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/cb0488826f8e

Comment 10

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: We need this for the Firefox Suggest preferences redesign targeting 95/94.

Comment 11

[Drew Willcoxon :adw]

Comment on attachment 9250462 [details]
Bug 1740345 - Land final strings for Firefox Suggest preferences redesign.

Beta/Release Uplift Approval Request

• User impact if declined: We need this for the Firefox Suggest preferences redesign targeting 95/94.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 5
• List of other uplifts needed: Please see uplift spreadsheet: https://docs.google.com/spreadsheets/d/1LavihS-VOPFYEyum7mrx6FKXmuQeHi9xQHfGNSxjnoY/edit?usp=sharing
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a en-US strings-only patch, and the strings are not exposed to localizers and do not need localization.
• String changes made/needed:

Comment 12

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this bug on the latest Beta 95.0b8 build (Build ID: 20211116185800) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

• The strings are correctly displayed as described in comment 5 for each scenario.

Comment 13

[Cosmin Muntean [:cmuntean], Ecosystem QA]

We have verified this bug on Firefox 94.0.2 try build on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

• The strings are correctly displayed as described in comment 5 for each scenario.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9250462 [details]
Bug 1740345 - Land final strings for Firefox Suggest preferences redesign.

Approved for 94.0.2.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/b18feb45bc8e

Comment 16

[Cosmin Muntean [:cmuntean], Ecosystem QA]

We have verified this bug on Firefox 94.0.2 candidate build (Build ID: 20211117154346) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

• The strings are correctly displayed as described in comment 5 for each scenario.