1740604 - popup blocker exceptions no longer works in 91.3 oesr

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[RNR1995]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Before update to 91.3 popup blocker exceptions where working fine

Actual results:

After update they no longer function correctly
Must disable popup blocker for the page to be displayed
Firefox does display the fact that it did block the popup window in the upper left hand corner

Expected results:

Exceptions should have been honored
Tried removing all exceptions, clearing cache etc. and re-entering exceptions
Same result
Just an FYI
thank you
Ron

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Application Update' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Robin Steuber (she/her) [:bytesized]]

Looks like bugbug got this one wrong, because this is not a problem with the Application Updater. It looks to me like other bugs regarding popup blocking are in Core :: DOM: Core & HTML, so hopefully that will be a better place for this.

Comment 3

[Edgar Chen [:edgar]]

(In reply to RNR1995 from comment #0)

Must disable popup blocker for the page to be displayed

Hi RNR1995, could you share which page you encounter this bug, so we could try to reproduce it, thanks!

Comment 4

[RNR1995]

Hello
I would have thought someone else has also experienced this as it happens on all my machines
I only have a few exceptions
hpe.com
microsoft.com
outlook.com
synnex.com
2 of these are vendors so unless someone has an account they will not have access
Ironically they are reproducible all the time
A few extra clicks to resolve
thank you
Ron

Comment 5

[Hsin-Yi Tsai (she/her)[:hsinyi]]

I logged in to microsoft.com and outlook.com. I wasn't able to reproduce on Firefox 94 on Win 10.

Dear reporter,
If you update to the latest version, is this issue still reproducible?

Comment 6

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #5)

I logged in to microsoft.com and outlook.com. I wasn't able to reproduce on Firefox 94 on Win 10.

Oh, I misread the bug.
I didn't get popup at all, even I disabled the popup blocker.
I did get popup on microsoft.com when I was using Edge or Chrome.

Dear reporter,
If you update to the latest version, is this issue still reproducible?

Comment 7

[RNR1995]

This is the latest version of ESR
popup blocker exceptions no longer works in 91.3 oesr?
It is not the end of the world, I just have to click on the other popup that states a popup was blocked then allow it
This was more a FYI to the programmers

Comment 8

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Popup blocker exception is more a front-end module, moving there.

Hi Ciprian,
I wonder if you can manage to reproduce this.

Comment 9

[Ciprian Georgiu, Desktop QA]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #8)

Popup blocker exception is more a front-end module, moving there.

Hi Ciprian,
I wonder if you can manage to reproduce this.

Hi! It appears that on my mac 11 and Win 11 machines with latest ESR 91.3.0, the pop-up is not triggered at all, when visiting microsoft.com or outlook.com websites. I can see the same behavior on Chrome or Edge, or when using on older version on Firefox ESR 91.2.0.

Comment 10

[Edgar Chen [:edgar]]

Hi Ciprian, it seems you can reproduce this, it would be super helpful if you could help to find the regression window. Thanks!

Comment 11

[Ciprian Georgiu, Desktop QA]

(In reply to Edgar Chen [:edgar] from comment #10)

Hi Ciprian, it seems you can reproduce this, it would be super helpful if you could help to find the regression window. Thanks!

I'm sorry if I was not clear enough in my last comment, the issue didn't reproduce for me on the mentioned builds. I'm afraid that I can help with the regression range in this case.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Hi RNR1995,

It seems we're having some difficulty reproducing this issue. Let's see if we can narrow this down a bit.

If you visit https://www.webroot.com/services/popuptester1.htm, it should attempt to open a single popup upon page load. In the notification bar, if you allow the popup, the popup should open.

Then, try closing the popup and reloading the page. Does the popup open for you without any additional interventions?

Comment 13

[RNR1995]

Hello, this has to do with the exceptions not being honored
So if I put webroot in the exceptions, webroot is still blocked
Where can I attach something here?

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Hi RNR1995,

So just to confirm, you were able to reproduce the issue on webroot, and you can never have the exception honoured?

Comment 15

[RNR1995]

Correct, and in the little window that usually allows me to allow a popup that is greyed out "Allow pop-ups for www.webroot.com"
I wish I could post a PIC
FWIW I have 3 similar machines all with 91.30esr on them
They all act the same
I find it even more peculiar that I am the only person experiencing this?????
Thank you
RNR

Just tried 94.02 on another PC and the first webroot test does not open 5 windows

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Thank you RNR1995.

On one of the machines you're experiencing this on - could you please go to about:support, click "Copy Text to Clipboard", and paste the clipboard contents into a new comment in this bug?

Comment 17

[RNR1995]

Attachment: about:support

Comment 18

[RNR1995]

Attachment: Mozilla.txt

Comment 19

[RNR1995]

Well that did not turn out like it was supposed to
let me know if it is OK

Comment 20

[Mike Conley (:mconley) (:⚙️)]

Thanks, RNR1995. One more thing to check:

Are you able to reproduce on any of the affected machines if you try in Troubleshoot Mode? (Help > Troubleshoot Mode).

Comment 21

[:Gijs (he/him)]

I think this is because the reporter is using permanent private browsing mode (browser.privatebrowsing.autostart: true from about:support). esr91 is a sad place because we disable the "allow site.com" entry in private browsing mode on esr91 (changed for Firefox 92 in bug 970675), but after bug 1680237 we don't honour non-private browsing exceptions in private browsing (although maybe that's happened for longer? Hard to know for sure). So the end result is that we end up with esr users in permanent private browsing unable to set exceptions, which is tedious. Of course, even on newer versions of Firefox the permissions aren't persisted if you close and restart the browser, but that's better than the esr status quo.

Paul, should we consider uplifting 970675 to esr?

Comment 22

[Emma Zühlcke [:emz]]

I'm not sure that this issue is critical enough to warrant an ESR uplift - a workaround exists. Permanent PBM already means you can't persist these permission past the session anyway. If you still think this should be uplifted, I suggest we only uplift https://phabricator.services.mozilla.com/D118887 which is the relevant fix and a small code change.

Comment 23

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1680237

Comment 24

[:Gijs (he/him)]

(In reply to Paul Zühlcke [:pbz] from comment #22)

I'm not sure that this issue is critical enough to warrant an ESR uplift - a workaround exists.

Does it? What's the workaround? I don't know what it'd be... AIUI exceptions added in about:preferences end up having non-private-browsing principals, so they don't get applied in PBM, either - or am I wrong about that? And I didn't think there was any other way to grant permission to the site... Allowing individual popups doesn't help if the website wants to use the return value of window.open afterwards and that JS has already run and failed.

Comment 25

[Emma Zühlcke [:emz]]

By workaround I meant allowing the pop-ups individually. But you make a very good point about the window.open return value. Sites can work around this by not having their pop-ups blocked, but users can't. Let's try to get this uplifted. I'll create a request.

Comment 26

[Emma Zühlcke [:emz]]

https://bugzilla.mozilla.org/show_bug.cgi?id=970675#c19

Comment 27

[:Gijs (he/him)]

The relevant patches have landed on the ESR branch so this will now be fixed in ESR 91.5, scheduled for release in January.