1680237 - Ship site permission isolation by private browsing

Status: VERIFIED FIXED

(Core :: Permission Manager, enhancement)

Description

[Paul Zühlcke [:pbz]]

We currently only set permissions.isolateBy.privateBrowsing for Nightly and early Beta. We should enable this for release as well.
This will separate private browsing and normal browsing permissions.

Comment 1

[Rares Doghi, Desktop QA]

Is this enhancement already in our latest Nightly builds ? because we are seeing different behavior from beta, If so the flags from this enhancement needs to be updated.

If the user reaches a Normal Window and checks Remember this Decision and clicks Allow when reaching a Private Window he will be asked again to Allow or Deny permissions ??

Also if he checks Remember this decision and the user clicks Don't Allow, will the same rule apply ? will he be asked again for permissions or it will be automatically denied ??

Comment 2

[Paul Zühlcke [:pbz]]

(In reply to Rares Doghi from comment #1)

Is this enhancement already in our latest Nightly builds ? because we are seeing different behavior from beta, If so the flags from this enhancement needs to be updated.

The patches in Bug 1422056 enabled isolation of permission for private browsing in Nightly. The behavior you're describing is expected in Nightly.
This bug is about enabling it for the release channel.

If the user reaches a Normal Window and checks Remember this Decision and clicks Allow when reaching a Private Window he will be asked again to Allow or Deny permissions ??

Yes, with the patch enabled, normal and private windows have separate permissions. Accepting or denying a permission prompt in a normal window won't change permissions for the private window (and vice versa).

Also if he checks Remember this decision and the user clicks Don't Allow, will the same rule apply ? will he be asked again for permissions or it will be automatically denied ??

The denied permission will not be shared with the private window, so the user will be asked again.

Comment 3

[Rares Doghi, Desktop QA]

Thank you for all the info.

Comment 4

[Paul Zühlcke [:pbz]]

I need to get back to Bug 1597751, the patch is stale at the moment. However, this shouldn't block us. The current default permissions imported here https://searchfox.org/mozilla-central/rev/3f97afc8db535f9b0232222cb48cc4cbf8334c76/browser/app/permissions aren't really needed in private browsing. The most important permission would be install. However, the permission check for that is skipped by the addon code if the addon is signed.

Comment 5

[Paul Zühlcke [:pbz]]

Attachment: Bug 1680237 - Enable permission isolation by private browsing for the release channel. r=johannh!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f2b9a785581
Enable permission isolation by private browsing for the release channel. r=johannh

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3f2b9a785581

Comment 8

[Rares Doghi, Desktop QA]

Hi Paul, I was trying to Verify this issue, it seems Fixed in Nightly 88 but it seems that its also been fixed for 87.0b5, Permissions for Normal and Private windows are separate now and the user is asked again in a Private Window regardles of what he allows or denies in a normal window.

Has the fix reached beta as well ? or am I missing something ?

Comment 9

[Paul Zühlcke [:pbz]]

Thanks for verifying! Permission isolation was already enabled in Nightly and early Beta. That's probably why you're seeing it in Beta already.

Comment 10

[Rares Doghi, Desktop QA]

This issue is Verified as Fixed in our Latest Nightly build 88.0a1 (2021-03-04) as well as 87.0b5 on Windows 10, Mac OsX 11.0 and Ubuntu 20.04.
Will there be an uplift for this one for Release 86 ?

Comment 11

[Paul Zühlcke [:pbz]]

We're still investigating whether Bug 1692567 is a result of PB permission isolation not enabled in release. Once we confirm that flipping the pref fixes it we'll try to get it uplifted into 87. Leaving NI for that.

Comment 12

[Paul Zühlcke [:pbz]]

Comment on attachment 9206388 [details]
Bug 1680237 - Enable permission isolation by private browsing for the release channel. r=johannh!

Beta/Release Uplift Approval Request

• User impact if declined: See Bug 1692567. Under special circumstances users can be get logged out of websites they've also visited in private browsing due to premature tracker purging.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pref flip only, has been enabled in Nightly and early Beta for 1 year already.
  Since we don't import default permissions for private browsing yet, users with custom default permissions may unexpectedly get prompted for permission again in private browsing. However, this is considered an edge-case.
• String changes made/needed:

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9206388 [details]
Bug 1680237 - Enable permission isolation by private browsing for the release channel. r=johannh!

approved for 87.0b7

Comment 14

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d3d980bafed4

Comment 15

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in 87.0b7 as well.
Will this issue be uplifted to Release 86 as well or can we update the status flag as well with Verified ?

Comment 16

[Paul Zühlcke [:pbz]]

(In reply to Rares Doghi from comment #15)

This issue is Verified as fixed in 87.0b7 as well.
Will this issue be uplifted to Release 86 as well or can we update the status flag as well with Verified ?

Thanks! No, we don't want to enable this in 86.

Comment 17

[Rares Doghi, Desktop QA]

Thanks, I will update the status flags.