1740799 - Format kotlin using ktlint

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Similar to Bug 1571899, we can use ktlint via spotless to format our kotlin code.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1740799 - Format Kotlin code using ktfmt.

Automatically generated running

./mach lint -l android-format --fix

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1740799 - Add ktfmt to android-format.

Comment 3

[Makoto Kato [:m_kato]]

I want this, so I take this.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1740799 - Format our Kolitin code. r=#geckoview-reviewers

Add ktlint-disable comment then reformat Kotlin code.

sed -i  -e 's/^\(import .*\.\*\)/\1 \/\/ ktlint-disable no-wildcard-imports/g'

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1740799 - Format Kotlin code using ktlint. r=#geckoview-reviewers

Android-component and Fenix use ktlint, so mozilla-central should use same
tools via spotless.

This is from https://phabricator.services.mozilla.com/D131018

Depends on D161556

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1740799 - Add android-format lint test. r=#linter-reviewers!,nalexander!

To run unit test for android-format lint, we have to add another simple Gradle
project. It is runs with specific parameter (androidFormatLintTest), so
./mach build etc doesn't run it.

Also type:global's lint doesn't have any test framework, so I will add it.

Depends on D161557

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19211084d916
Format our Kolitin code. r=geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/2078ec02a313
Format Kotlin code using ktlint. r=geckoview-reviewers,owlish,linter-reviewers,sylvestre
https://hg.mozilla.org/integration/autoland/rev/dabc0ae241c7
Add android-format lint test. r=nalexander,linter-reviewers,sylvestre

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/19211084d916
https://hg.mozilla.org/mozilla-central/rev/2078ec02a313
https://hg.mozilla.org/mozilla-central/rev/dabc0ae241c7