1740902 - Remove obsolete dom.storage.abort_on_sync_parent_to_child_messages preference and logic

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, task)

Description

[Jens Stutte [:jstutte]]

dom.storage.abort_on_sync_parent_to_child_messages is not needed anymore and always false.

Comment 1

[Joaquín Serna]

This is basically like reverting this commit, right?

I don't find any other occurrences of that preference key: https://searchfox.org/mozilla-central/search?q=abort_on_sync_parent_to_child_messages&path=

Comment 2

[Harveer Singh]

Attachment: Bug 1740902: Remove obsolete dom.storage.abort_on_sync_parent_to_child_messages preference and related logic. r=#dom-storage-reviewers,janv

Comment 3

[Jan Varga [:janv]]

(In reply to Joaquín Serna from comment #1)

This is basically like reverting this commit, right?

I don't find any other occurrences of that preference key: https://searchfox.org/mozilla-central/search?q=abort_on_sync_parent_to_child_messages&path=

Sorry for late reply ...
Yes, that commit, but there were other commits prior to that which needed to be reverted as well.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebef18795af8
Remove obsolete dom.storage.abort_on_sync_parent_to_child_messages preference and related logic. r=janv,dom-storage-reviewers

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ebef18795af8

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset ebef18795af8 (Bug 1740902) for frequent crash (Bug 1768691) CLOSED TREE
Backout link: https://hg.mozilla.org/integration/autoland/rev/a8c76fab6c0dd73628fc4b2a578ed81ebe808a88

Comment 7

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/0a4cbd771ad2

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1740902 - Don't abort the event loop spinning before the request is actually finished; r=#dom-storage

We don't abort the event loop spinning before the request is actually finished
because that would cause races between the current thread and DOM File thread.
Instead, we send the cancel message to the parent and wait for the request to
finish like in the normal case when the request is successfully finished on
time. OnResponse is called as the final step in both cases.

Comment 9

[Harveer Singh]

Attachment: Bug 1740902: Remove obsolete dom.storage.abort_on_sync_parent_to_child_messages preference and related logic. r=#dom-storage-reviewers,janv

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0490bf75e06c
Remove obsolete dom.storage.abort_on_sync_parent_to_child_messages preference and related logic. r=janv,dom-storage-reviewers
https://hg.mozilla.org/integration/autoland/rev/0408e5bc277d
Don't abort the event loop spinning before the request is actually finished; r=hsingh

Comment 11

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/0490bf75e06c
https://hg.mozilla.org/mozilla-central/rev/0408e5bc277d