1768691 - Crash in [@ mozilla::dom::(anonymous namespace)::RequestHelper::OnResponse]

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

61 crashes from 26 installations, all with Firefox 102.0a1 20220510095538 => should be a regression from bug 1740902.

Crash report: https://crash-stats.mozilla.org/report/index/c123c240-1618-41ad-848e-4fbc80220510

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (NS_SUCCEEDED(mNestedEventTarget->Dispatch(this, nsIEventTarget::DISPATCH_NORMAL)))

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::`anonymous namespace'::RequestHelper::OnResponse dom/localstorage/LSObject.cpp:1266
1 xul.dll mozilla::dom::LSRequestChild::Recv__delete__ dom/localstorage/ActorsChild.cpp:204
2 xul.dll mozilla::dom::PBackgroundLSRequestChild::OnMessageReceived ipc/ipdl/PBackgroundLSRequestChild.cpp:189
3 xul.dll mozilla::ipc::PBackgroundChild::OnMessageReceived ipc/ipdl/PBackgroundChild.cpp:6519
4 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1583
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1174
6 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:330
7 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:373
8 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:355
9 xul.dll static nsThread::ThreadFunc xpcom/threads/nsThread.cpp:378

Comment 1

[Jan Varga [:janv]]

I think I know what's wrong, let me verify it.

Comment 2

[Harveer Singh]

Ya I think after my changes mNestedEventTarget is no longer handling the case 'NS_ERROR_UNEXPECTED' on the Dispatch call. I don't think I see this particular failure on my treeherder run or probably I skipped the failure thinking of it as an intermittent.

It might be better to invoke a treeherder run after your changes @JanV

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1740902 got backed out. Closing under the assumption the issue will be handled there.

Comment 4

[Woyece]

@pascalc Same issue here: https://crash-stats.mozilla.org/report/index/c5bb9423-8ea6-46cc-90d4-3fc6a0220510#tab-bugzilla

Comment 5

[Woyece]

Firefox 102.0a1 Crash Report [@ mozilla::dom::(anonymous namespace)::RequestHelper::OnResponse ]

Comment 6

[Woyece]

[Tracking Requested - why for this release]:

Comment 7

[Pascal Chevrel:pascalc]

(In reply to Woyece from comment #5)

Firefox 102.0a1 Crash Report [@ mozilla::dom::(anonymous namespace)::RequestHelper::OnResponse ]

This is an old crash report on an old nightly build which doesn't contain the fix.