1740989 - Form inputs remain focused when disabled (focus fixup rule not followed)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Evgeny Kapun]

Steps to reproduce:

Try the following code:

HTML:
<input id=foo>

JavaScript:
foo.focus();
foo.disabled = true;
console.log(document.activeElement);

Actual results:

The value logged is the input element.

Expected results:

According to the HTML specification, the document's body element should have been logged instead. Chromium behaves according to the specification, but Firefox doesn't.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Console' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Another test-case.

Chrome seems to implement the fixup rule somewhat inconsistently. It works for disabled, but not for other stuff that affects focusability like visibility or so.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Not even display: none, for that matter.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Refined test-case.

It seems Blink implements this at some point after the RAF callbacks but before rendering. Need to check the spec but I think it's about time to fix this.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1740989 - Implement focus fixup rule. r=smaug

This implements the proposal in the linked spec issue, and makes
it nightly-only pending resolution + edits.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8f983951128
Implement focus fixup rule. r=smaug

Comment 7

[Iulian Moraru]

Backed out for causing mochitest-chrome failures on test_modal_prompts.html.

Push with failures

Failure log

Backout link

[task 2022-08-31T21:49:32.358Z] 21:49:32     INFO - TEST-PASS | toolkit/components/prompts/test/test_modal_prompts.html | Checking cancel-button isn't disabled 
[task 2022-08-31T21:49:32.359Z] 21:49:32     INFO - Buffered messages finished
[task 2022-08-31T21:49:32.359Z] 21:49:32     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/prompts/test/test_modal_prompts.html | checking button0 default - got true, expected false
[task 2022-08-31T21:49:32.359Z] 21:49:32     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:497:14
[task 2022-08-31T21:49:32.359Z] 21:49:32     INFO - checkPromptState@chrome://mochitests/content/chrome/toolkit/components/prompts/test/prompt_common.js:291:5
[task 2022-08-31T21:49:32.360Z] 21:49:32     INFO - handlePrompt@chrome://mochitests/content/chrome/toolkit/components/prompts/test/prompt_common.js:196:19
[task 2022-08-31T21:49:32.360Z] 21:49:32     INFO - TEST-PASS | toolkit/components/prompts/test/test_modal_prompts.html | checking button1 default 

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81580b85d04c
Implement focus fixup rule. r=smaug

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/81580b85d04c