1792057 - Changing the type of an <input> triggers a blur

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Calixte Denizet (:calixte)]

Attachment: plop5.html

I'd like to use the date input in pdf.js for pdf forms, but the display of unfocused fields can depend on some embedded scripts, hence the idea to switch from an <input type=date> to <input type=text>, but for any reason, once the type is changed a blur is triggered.
FYI, it works as expected in Chrome.

Comment 1

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

Hi Adam, would you care to put this into your queue and investigate a bit?

Comment 2

[Adam Vandolder [:avandolder]]

Yep, for sure. This seems to be a very recent regression; for me the attached test only fails in Nightly, but works the same as Chrome in the current Beta and Release builds.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Mozregression points to bug 1740989, I know what's going on and fix is trivial, but I need to write a test.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1740989

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792057 - Make sure to focus inner text field when creating / rebuilding edit fields in datetime widget. r=smaug

The blur is a regression from bug 1740989, but it's really uncovering a
regression from bug 1729342, sorta. Before that, we used to focus the
inner text field on rebuild via focusInnerTextBox().

One could argue that the focus fixup rule should really deal with this,
but I guess since content can't really unattach shadow DOM, it's less of
a general issue and more of an implementation detail.

The test uncovers another pre-existing (annotated) issue. I'll file a
follow-up for that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4edc81a94eaa
Make sure to focus inner text field when creating / rebuilding edit fields in datetime widget. r=smaug

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36293 for changes under testing/web-platform/tests

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c3c78eca109
Backed out changeset 4edc81a94eaa for causing multiple failures. CLOSED TREE

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for causing multiple failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/3c3c78eca1097b1fc359f87bdf5d6f5882e6c1d7
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4edc81a94eaa522befc096d01708a7217e3109fa
• failure logs:
  • TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_toolbar_fields.js | Element left border color should be set. - "rgba(0, 0, 0, 0)" == "rgb(170, 170, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 83
  • TEST-UNEXPECTED-FAIL | /css/selectors/focus-within-009.html | Detach 'container1' from the document - assert_array_equals: lengths differ, expected array [] length 0, got ["html", "body", "test"] length 3
  • REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/731726-1.html == layout/reftests/bugs/731726-1-ref.html | image comparison, max difference: 255, number of differing pixels: 128
  • TEST-UNEXPECTED-FAIL | /shadow-dom/focus/focus-pseudo-matches-on-shadow-host.html | :focus behavior on tree structure changes; {mode:open, delegatesFocus:false} - assert_false: expected false got true
  • TEST-UNEXPECTED-FAIL | dom/events/test/test_moving_and_expanding_selection_per_page.html | Expanding selection to forward in non-scrollable body: selection should be expanded into the last line (got: text node in span#s1) - got [object Text], expected [object Text]
  • TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_root_element_replacement.html | the content of body text isn't 'ABC' -- Replace to '<html contenteditable='true'><body></body></html> - got "BC", expected "ABC"
  • TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_addon_list_reordering.js | cardOne is still in enabled - Got "extension-disabled-heading", expected "extension-enabled-heading"

Comment 11

[Donal Meehan [:dmeehan]]

Looks like this is too late for 107, attached patch was backed out
Leaving 108 clear, unless anyone thinks we should be following this for a fix in 108?

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14c3be47e102
Make sure to focus inner text field when creating / rebuilding edit fields in datetime widget. r=smaug

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/14c3be47e102

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot