1741132 - Correctly evict entries with session history in parent

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Peter Van der Beken [:peterv]]

Current with SHIP we evict entries when we set a frameloader on the entry. However, this happens before we commit the entry. As a result we leave one entry too many when evicting, because we're not counting the entry that we just set the frameloader on. Evicting from CanonicalBrowsingContext::HistoryCommit seems to fix this, but I'm not sure whether we need to keep doing the eviction when setting the frameloader.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1741132 - Add a property for whether an entry is in the BFCache (holds a content viewer or a frame loader). r?smaug!

Depends on D131892

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Bug 1741132 - Correctly evict entries with session history in parent. r?smaug!

Depends on D131893

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ad268a75fec
Add a property for whether an entry is in the BFCache (holds a content viewer or a frame loader). r=smaug
https://hg.mozilla.org/integration/autoland/rev/9b91c4d469d7
Correctly evict entries with session history in parent. r=smaug

Comment 4

[Marian-Vasile Laza]

Backed out 4 changesets (Bug 1741132, Bug 1740516, Bug 1740517) for causing mochitest failures on test_bug1741132.html.
Backout link
Push with failures
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18b226a67f6d
Add a property for whether an entry is in the BFCache (holds a content viewer or a frame loader). r=smaug
https://hg.mozilla.org/integration/autoland/rev/56a1fce20849
Correctly evict entries with session history in parent. r=smaug

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/18b226a67f6d
https://hg.mozilla.org/mozilla-central/rev/56a1fce20849