1741808 - Enable devtools.every-frame-target.enabled on Nightly

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Let's have this bake in Nightly for a bit so we can get feedback

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1741808 - [devtools] Fix increased failures on browser_toolbox_backward_forward_navigation.js when EFT is enabled. r=ochameau.

Depends on D131471

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1741808 - [devtools] Make browser_resources_document_events.js handle EFT. r=ochameau.

Depends on D131475

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1741808 - [devtools] Enable EFT on Nightly. r=ochameau,bomsy.

Depends on D131476

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a091d9b9bee6
[devtools] Fix increased failures on browser_toolbox_backward_forward_navigation.js when EFT is enabled. r=ochameau.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

oh shoot, I forgot I attached the test fixes to this bug when landing them

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a091d9b9bee6

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1741808 - [devtools] Fix more frequent failures on browser_dbg-event-breakpoints-fission.js when EFT is enabled. r=bomsy.

Depends on D131476

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1741808 - [devtools] Fix server chrome inspector test when EFT is enabled. r=ochameau.

We were always using the top level walker front, but as some tests are using iframes,
we need to use the node fronts dedicated walker front instead.
test_inspector-dead-nodes.html is purely skipped when EFT is enabled as it triggers
failures more frequently and it doesn't make much sense anyway (this test will be
migrated to a command test when we move walkerFront#children to a command).

Depends on D131598

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1741808 - Enable devtools no eft config. r=jdescottes.

Since we're going to enable EFT on Nightly and let it bake there a bit to
get feedback, we might face a situation where we have to disable EFT.
Having these test variants will help us to not regress non-EFT cases so if
we ever have to rollback EFT, there wouldn't be extra work.

Depends on D131477

Comment 10

[Phabricator Automation]

Comment on attachment 9251317 [details]
Bug 1741808 - [devtools] Make browser_resources_document_events.js handle EFT. r=ochameau.

Revision D131476 was moved to bug 1742330. Setting attachment 9251317 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9251543 [details]
Bug 1741808 - [devtools] Fix more frequent failures on browser_dbg-event-breakpoints-fission.js when EFT is enabled. r=bomsy.

Revision D131598 was moved to bug 1742331. Setting attachment 9251543 [details] to obsolete.

Comment 12

[Phabricator Automation]

Comment on attachment 9251544 [details]
Bug 1741808 - [devtools] Fix server chrome inspector test when EFT is enabled. r=ochameau.

Revision D131599 was moved to bug 1742329. Setting attachment 9251544 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9251545 [details]
Bug 1741808 - Enable devtools no eft config. r=jdescottes.

Revision D131600 was moved to bug 1742332. Setting attachment 9251545 [details] to obsolete.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f637151059d
[devtools] Enable EFT on Nightly. r=bomsy.

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9f637151059d

Comment 16

[Cristian Tuns]

Backed out for causing damp failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | damp | inspector/custom.js: Test timed out

Comment 17

[Nicolas Chevobbe [:nchevobbe]]

Filed Bug 1742800 for this failure

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/810cfde65f6f
[devtools] Enable EFT on Nightly. r=bomsy.

Comment 19

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/810cfde65f6f