1741915 - Crash in [@ pthread_mutex_lock | arena_dalloc | free | webrender_api::DynamicProperties::extend]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/06272d1c-b1a7-4425-a7e9-69f8c0211118

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0 libpthread.so.0 pthread_mutex_lock /build/glibc-zwSIJz/glibc-2.27/nptl/pthread_mutex_lock.c:67
1 firefox arena_dalloc /build/firefox-61spvY/firefox-94.0+build3/memory/build/mozjemalloc.cpp:3370
2 firefox free /build/firefox-61spvY/firefox-94.0+build3/memory/build/malloc_decls.h:54
3 libxul.so webrender_api::DynamicProperties::extend /build/firefox-61spvY/firefox-94.0+build3/gfx/wr/webrender_api/src/lib.rs:493
4 libxul.so webrender::scene::SceneProperties::add_properties /build/firefox-61spvY/firefox-94.0+build3/gfx/wr/webrender/src/scene.rs:56
5 libxul.so webrender::render_backend::RenderBackend::update_document /build/firefox-61spvY/firefox-94.0+build3/gfx/wr/webrender/src/render_backend.rs:1287
6 libxul.so webrender::render_backend::RenderBackend::process_api_msg /build/firefox-61spvY/firefox-94.0+build3/gfx/wr/webrender/src/render_backend.rs:1049
7 libxul.so std::sys_common::backtrace::__rust_begin_short_backtrace /build/rustc-eG77Xy/rustc-1.53.0+dfsg1+llvm/library/std/src/sys_common/backtrace.rs:125
8 libxul.so core::ops::function::FnOnce::call_once{{vtable.shim}} /build/rustc-eG77Xy/rustc-1.53.0+dfsg1+llvm/library/core/src/ops/function.rs:227
9 libxul.so std::sys::unix::thread::Thread::new::thread_start /build/rustc-eG77Xy/rustc-1.53.0+dfsg1+llvm/library/std/src/sys/unix/thread.rs:71

I was looking at the Linux top crash list for 94.0, and I noticed there were a lot of signatures with DynamicProperties::extend in them and there was no bug on file, so I decided I should file a bug. I don't see any of these crashes in 94.0.1, but there was apparently only one OSX fix so maybe most users haven't updated on Linux.

Maybe this is related to the EGL switch?

Comment 1

[Andrew McCreight [:mccr8]]

[Tracking Requested - why for this release]: These crashes together look to be about 15% of all Linux crashes in 94.0.

Comment 2

[Andrew McCreight [:mccr8]]

Looking at the comments, there are a number complaining that it is happening frequently for them, and that they only started experiencing this.

Comment 3

[Andrew McCreight [:mccr8]]

90% or so of the crashes with DynamicProperties in them have adapter driver version 20.0.8.0, which I think means it isn't related to EGL?

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

This seems to be happening almost exclusively on 32-bit x86 Ubuntu 18.04 and derivatives of that release.

Comment 5

[Andrew McCreight [:mccr8]]

Around half of the crashes have zero available page file, and the crashes are all in the parent process, so that does seem consistent with it being some kind of OOM, which we'd expect to be more common on 32 bit systems.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Looks like bug 1739924 fixed this.