1741959 - Move audio data processing to ProcessInput

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, task, P1)

Description

[C.M.Chang[:chunmin]]

The interface for getting the data source of the AudioInputProcessing is in NotifyInputData now. It's better to get its data source from ProcessInput instead. In ProcessInput, we should be able to take an AudioSegment AudioInputTrack's input port souce, so AudioInputTrack can process data from any kind of MediaTrack

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1741959 - Remove useless comment

This comment should be deleted in Bug 1725810.

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1741959 - Add debugging logs

Depends on D127605

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1741959 - Move NativeInputTrack to individual files

The following patches will add an abstract MediaTrack for the audio
input devices. The NativeInputTrack will be one implementation of it.
These MediaTracks holding the audio input data should be put together so
this patch moves the NativeInputTrack into individual .h and .cpp files,
which will also be the places implementing this new type of MediaTrack.

Depends on D125626

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1741959 - Move audio data processing to ProcessInput

The interface for getting the data source of the AudioInputProcessing in
AudioInputTrack is moved from AudioInputProcessing::NotifyInputData to
::ProcessInput, which takes an AudioSegment forwarded from the
AudioInputTrack's source track

Depends on D117965

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1741959 - Add test for NativeInputTrack

Add a simple test checking the data from NativeInputTrack

Depends on D122513

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1741959 - Use Maybe for AudioPacketizer to avoid allocations

Depends on D117965

Comment 7

[C.M.Chang[:chunmin]]

Attachment: Bug 1741959 - Set a default PrincipalHandle to DeviceInputTrack

Replace the data principal in DeviceInputTrack PRINCIPAL_HANDLE_NONE
by a MediaTrackGraph system principal

Depends on D122513

Comment 8

[Phabricator Automation]

Comment on attachment 9252036 [details]
Bug 1741959 - Set a default PrincipalHandle to DeviceInputTrack

Revision D131871 was moved to bug 1746735. Setting attachment 9252036 [details] to obsolete.

Comment 9

[Phabricator Automation]

Comment on attachment 9251426 [details]
Bug 1741959 - Add test for NativeInputTrack

Revision D130232 was moved to bug 1746735. Setting attachment 9251426 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9de2c0343e5a
Remove useless comment r=padenot
https://hg.mozilla.org/integration/autoland/rev/a1a835bfd32c
Add debugging logs r=padenot,pehrsons
https://hg.mozilla.org/integration/autoland/rev/560f9a2d8a5a
Move NativeInputTrack to individual files r=padenot,pehrsons
https://hg.mozilla.org/integration/autoland/rev/8a828e078a37
Use Maybe for AudioPacketizer to avoid allocations r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/d4ceca3a925a
Move audio data processing to ProcessInput r=padenot,pehrsons

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9de2c0343e5a
https://hg.mozilla.org/mozilla-central/rev/a1a835bfd32c
https://hg.mozilla.org/mozilla-central/rev/560f9a2d8a5a
https://hg.mozilla.org/mozilla-central/rev/8a828e078a37
https://hg.mozilla.org/mozilla-central/rev/d4ceca3a925a