Open Bug 1742111 Opened 4 years ago Updated 2 years ago

Rename internal accentcolor and textcolor properties to be more consistent with the webext theme API

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Type:
task
Points:
2

Tracking

()

Status:
REOPENED
Iteration:
96.2 - Nov 15 - Nov 28

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1742111 - Rename internal accentcolor and textcolor properties to be more consistent with the webext theme API. r=harry
48 bytes, text/x-phabricator-request
Details | Review

This has come up as a source of confusion while reviewing the patch in bug 1741931.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c47ea741114 Rename internal accentcolor and textcolor properties to be more consistent with the webext theme API. r=harry
Iteration: --- → 96.2 - Nov 15 - Nov 28

https://hg.mozilla.org/mozilla-central/rev/8c47ea741114

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Regressions: 1742237

Backed out for causing Bug 1742237.

Status: RESOLVED → REOPENED
status-firefox96: fixed → ---
Resolution: FIXED → ---
Target Milestone: 96 Branch → ---
Flags: needinfo?(dao+bmo)
Backout by abutkovits@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/18553c1a1cce Backed out changeset 8c47ea741114 for causing Bug 1742237. a=backout
Flags: needinfo?(dao+bmo)

Is this bug still valid?

Flags: needinfo?(dao+bmo)

(In reply to Richard Marti (:Paenglab) from comment #6)

Is this bug still valid?

Yeah: https://searchfox.org/mozilla-central/search?q=accentcolor&path=theme&case=true&regexp=false

Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: