Closed Bug 1742203 Opened 2 years ago Closed 2 years ago

Tweak lazy-loading root margin defaults to 500px in all directions

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: sefeng, Assigned: sefeng)

References

Details

Attachments

(1 file)

In bug 1722574, we conclude that anything that is over 600px isn't going to work. To be precise, let's try 500px and see how it works.

Assignee: nobody → sefeng
Status: NEW → ASSIGNED
Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/564dbd9e1b5f
Tweak lazy-loading root margin defaults to 500px in all directions for EARLY_BETA_OR_EARLIER r=emilio
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch

Sean do we have data on this now to decide whether we stick with 500 or just use the release value?

Flags: needinfo?(sefeng)

Compare 500px to 600px:

lazyload_image_not_viewport: On par with 600px for 95% percentile, a slight improvement (down from 3 images to 2 images) for 75 percentile.
lazyload_image_viewport_loaded: This one is generally hard to interpret because the data is quite noisy. Looks mostly on par, or very tiny regression at some point.
lazyload_image_viewport_loading: A regression compare to 600px as more images (From 14 images to 17 images for 95 percentile) were still loading.
fx_lazyload_image_page_load_ms: The page load data seems not reliable. We get a ~6% regression compare to 600px, which is mysterious.

Compare 500px to 300px (original value before any tweaks):

lazyload_image_not_viewport: Slight regression for most of the data points. (7 images to 8 images for 95 percentile, and 1 images to 2 images for 75 percentile).
lazyload_image_viewport_loaded: Seems like a slight improvement (18 images to 19 or 20 images).
lazyload_image_viewport_loading: On par.
fx_lazyload_image_page_load_ms: We get a ~5% regression, however as I said earlier, page load data seems not reliable.

I think given the above data, I think if we are okay with some regression to lazyload_image_not_viewport, we should tweak the value to 600px. The summary for 600px is https://bugzilla.mozilla.org/show_bug.cgi?id=1713811#c0. I'll make a bug for it.

Flags: needinfo?(sefeng)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: