1742236 - Icon in Address Bar Covered

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[whatifmaybe]

Attachment: address_bar_1.png

Steps to reproduce:

Opened a PDF attachment or any content (like the release notes), which are making use of the address bar in Thunderbird Mac.

Actual results:

The address in the address bar is lacking a bit of margin to the left and hence the magnifier icon is not fully visible.

Expected results:

The magnifier icon should be visible.

Comment 1

[whatifmaybe]

Attachment: address_bar_2.png

Comment 2

[WaltS48 [:walts48]]

Do you have an extension providing this magnifier icon?

Possibly it needs an update.

Comment 3

[whatifmaybe]

(In reply to WaltS48 [:walts48] from comment #2)

Do you have an extension providing this magnifier icon?

Possibly it needs an update.

The icon doesn't seem to be related to an extension. Starting Thunderbird in Troubleshoot Mode or with a new profile doesn't change the icon in the address bar.

Comment 4

[WaltS48 [:walts48]]

So, I have a bug in my Windows and Linux versions of Thunderbird for not showing that magnifier at all?

Using any accessibility features on your Mac?

Comment 5

[whatifmaybe]

No accessibility features in use. It's the same behaviour with a fresh install.

Comment 6

[WaltS48 [:walts48]]

I don't see, or ever recall seeing, a magnifier in the address bar.
The only magnifiers are in the Search bars.

Just tested with 91.3.2 on Windows 10.

Comment 7

[whatifmaybe]

Tested again with a new Mac and clean Thunderbird – same result. Is there anything I should do to further investigate?

Comment 8

[WaltS48 [:walts48]]

(In reply to whatifmaybe from comment #7)

Tested again with a new Mac and clean Thunderbird – same result. Is there anything I should do to further investigate?

Do you have it in Firefox if you open this PDF Test file in the PDF Viewer there?

I do not.

Comment 9

[whatifmaybe]

(In reply to WaltS48 [:walts48] from comment #8)

(In reply to whatifmaybe from comment #7)

Tested again with a new Mac and clean Thunderbird – same result. Is there anything I should do to further investigate?

Do you have it in Firefox if you open this PDF Test file in the PDF Viewer there?

I do not.

No, does only occur in Thunderbird Mac.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1742236-contentTabUrlInput-no-icon.patch

The class seems to be renamed and the old rule did no more apply.

Comment 11

[Alessandro Castellani [:aleca]]

The patch fixes it, but this styling is a bit strange and inconsistent across platforms.

This seems to be a band-aid fix to solve platform inconsistencies created in m-c. (band-aid is not a term to attack anyone that worked on these files, it's just to represent the fact that we're adding some extra styling to fix something sketchy coming from m-c).

So, we have the .themeableSearchBox that adds the magnifying glass background image, but only on macOS: https://searchfox.org/comm-central/rev/a1a691cfdef5898ea4f53861c2592085a039bb43/mail/themes/osx/mail/searchBox.css#23-32

It seems that we do this also for the .searchBox element, and from what I can tell it's because that element is styled from m-c with the magnifying icon on Linux and Windows but not macOS: https://searchfox.org/mozilla-central/rev/6a7c3a1eda4ebb8f9c13779dbbf5eff15bacf8ed/toolkit/themes/linux/global/search-textbox.css#51-54

This is so weird, but unless m-c decides to drop those shadow dom elements and add a consistent styling, we're stuck with this way.

Since we have other areas in which we use the .themeableSearchBox class alongside the .contentTabUrlInput class, wouldn't be better to update that CSS declaration with .themeableSearchBox:not(.contentTabUrlInput)? Would that properly cover all scenarios where we use the themeableSearchBox in a fake url bar in a Content tab?

Another possible, more permanent, solution might be to remove the themeableSearchBox class from those elements that are not actually searchable input fields.

Comment 12

[Richard Marti (:Paenglab)]

Attachment: 1742236-contentTabUrlInput-no-icon.patch

On Mac first the search glass was automatically added to the search widget from the system. But with the CE changes this was added through CSS.

The :not(.contentTabUrlInput) is the best approach.

Removing the themeableSearchBox class would need that we copy most of the code for this element

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/94ce1c0b76bf
Hide the search glass on URL inputboxes. r=aleca

Comment 14

[Richard Marti (:Paenglab)]

Comment on attachment 9254149 [details] [diff] [review]
1742236-contentTabUrlInput-no-icon.patch

[Approval Request Comment]
User impact if declined: double icon in "URL" bar on Mac
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 15

[Richard Marti (:Paenglab)]

Attachment: 1742236-contentTabUrlInput-no-icon-ESR.patch

[Approval Request Comment]
User impact if declined: double icon in "URL" bar on Mac
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9254149 [details] [diff] [review]
1742236-contentTabUrlInput-no-icon.patch

[Triage Comment]
Approved for beta

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 96.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/4ea24d08872b

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9254331 [details] [diff] [review]
1742236-contentTabUrlInput-no-icon-ESR.patch

[Triage Comment]
Approved for esr91

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/397bd1524355