1742299 - nightly settings page wrong colors for dark theme, 20211121

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[[e-mail]]

Attachment: nightly_showing_settings_page_black_on_white_dark_theme.png

Steps to reproduce:

Updated to the latest nightly tar package build.

Actual results:

The settings page became black text on white background when using a dark theme.

Expected results:

Settings page matches the dark theme. As issues go, this is pretty minor, but I thought I would note it.

Comment 1

[[e-mail]]

Attachment: nightly_showing_settings_page_correct_for_dark_theme.png

This is what it should look like.

Comment 2

[[e-mail]]

I'm having some other issues with my system, but if I get a chance I will run a mozregression to determine the patch set that caused this.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[Celeste Liu [:Coelacanthus]]

I found it maybe caused by resetting browser.theme.toolbar-theme to 0 when firefox start.
I try to use user.js to set browser.theme.toolbar-theme to default value 2 but it doesn't work.

Comment 5

[Pablo]

Hi,

What linux distro are you using?
Im on windows10 and Ubuntu 20 and the dark theme shows about:preferences in dark color.

Does this issue occur with a fresh profile? you can find the steps here: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

regards.

Comment 6

[[e-mail]]

I'm using Fedora, the problem occurs in both F31 and rawhide (future f36). I would have regression tested this to find the commit which is causing the problem, but I am having a problem with the graphics on F36. I'll try to reproduce it on F31.

Thank you to those who are working on this. It does not occur with a fresh profile. I investigated why. My settings for color are custom, and I use them always. That results in the incorrect behavior. I will attach a screenshot of the settings, with the settings tab ignoring them in the background.

Comment 7

[[e-mail]]

Attachment: nightly_showing_settings_page_with_custom_colors_selected_always.png

This is a screen capture with a background of the settings page showing the problem, and the custom colors I have set that are causing it. I think the key thing is that when I use the custom colors, I always select the always option for when to use them. The blue of unvisited links is terrible for me to read, and I prefer the yellow for visited links. If I want those link colors, I have to set the text and background to dark compatible so that I still get dark theme.

Comment 8

[[e-mail]]

I did a mozregression on the issue. It went back further than I thought, it must have taken me time to notice it. The results:

10:17.73 INFO: No more integration revisions, bisection finished.
10:17.73 INFO: Last good revision: 93c734e36aac9ad7db8f7d779683054f2203a431
10:17.73 INFO: First bad revision: eaed626461dbad3115cd3574b68e6a3a83bd35c4
10:17.73 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=93c734e36aac9ad7db8f7d779683054f2203a431&tochange=eaed626461dbad3115cd3574b68e6a3a83bd35c4

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733413

Comment 11

[Mathew Hodson]

I believe this was fixed by bug 1733413. Does the problem still occur for you?

Comment 12

[Mathew Hodson]

I meant to say I think it's fixed by bug 1735800.

Comment 13

[[e-mail]]

Yes, the settings page is still white with black text. If I enter the colors menu and tell nightly to never override the colors of the page rather than always override, the problem goes away. As soon as I switch back to using my custom color scheme always overriding the colors of the page, it returns to black text on white background. So, this is a very obscure corner case. The intersection of people who use custom colors always with people who use a dark theme.

The problem in https://bugzilla.mozilla.org/show_bug.cgi?id=1751735 is fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1735800.

Comment 14

[[e-mail]]

This bug is now fixed. It happened with the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1762018. So, I am closing it. If someone else is experiencing the problem, and still has it, they should re-open it, or possibly open a new bug, because their problem is different than what was causing my problem.