1742458 - Custom fields, especially ones shown or hidden by BMO extension are not consistenly show or hidden across UI and API

Status: NEW

(bugzilla.mozilla.org :: API, defect)

Description

[Calixte Denizet (:calixte)]

For example:
https://bugzilla.mozilla.org/show_bug.cgi?id=1572618
the crash signature isn't empty, but
https://bugzilla.mozilla.org/rest/bug/1572618
doesn't show it and
https://bugzilla.mozilla.org/rest/bug/1572618/history
shows that some changes have been made in this field.

Comment 1

[David Lawrence [:dkl]]

Ok so we have some inconsistency (big shocker) in the Bugzilla code when it comes to hiding certain custom fields in different views.

So basically we have a hard coded list of products which the crash signature field is supposed to display for only which the "Firefox Build System" is not in the list. The fill list can be seen at https://github.com/mozilla-bteam/bmo/blob/master/extensions/BMO/lib/Data.pm#L101-L138.

The REST API honors that list which explains why it does not display for the bug in question in the API bug call. But the show bug UI does allow the crash signature to always be displayed regardless of the above product list.

And it seems we also do not block setting the crash signature value via the REST API even if it supposed to be hidden for the product. So the release automation bot was able to set the value.

So I need to figure out how to make all of this consistent across the API and the UI. The quick quick fix is to just add "Firefox Build System" to the list of allowed products which will fix the issue of it not displaying in the REST API JSON data.

Comment 2

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 3

[David Lawrence [:dkl]]

Committed the quick fix. Will leave this bug open to fix the bigger inconsistency issues.
https://github.com/mozilla-bteam/bmo/commit/641aa22f731cff07801f3803881e6e4ed040204d