Closed Bug 1742696 Opened 1 year ago Closed 1 year ago

Text selection colors look differently between about:support and about:cache

Categories

(Toolkit :: General, defect, P3)

defect

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: itiel_yn8, Assigned: emilio)

References

Details

Attachments

(4 files)

Attached image about:support

This on Windows, latest Nightly, dark mode enabled.

Attached image about:cache
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Component: Video/Audio Controls → General
Flags: needinfo?(emilio)

Privileged pages do this automatically via:

https://searchfox.org/mozilla-central/rev/aa8c75b83f636948f708986173965c84cae8c25f/widget/nsXPLookAndFeel.cpp#1179-1183

So this makes everything more consistent. Known exceptions:

  • Pocket panels (as those don't seem to support dark mode)
  • about:reader (because it has its own dark mode handling)

This does not seem to block any functionality. So setting severity to S4.

Severity: -- → S4
Priority: -- → P3

This should have roughly the same effect as the meta tag, and all these
pages support dark mode. The meta tag still has its merits (it allows us
to conceptually paint a dark background sooner to avoid flashing white).

I'd still prefer to keep the meta tag but this might be a simpler fix.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d8f5e98cfa4
Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/65c077e5607f
Remove accidentally-duplicated meta tag. a=NarcisB
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/409807080a65
Also add color-scheme to in-content/common. r=Gijs
Blocks: 1743102
You need to log in before you can comment on or make changes to this bug.