Closed Bug 1742697 Opened 2 years ago Closed 1 year ago

Update string cases on buttons to be sentence-case instead of title-case

Categories

(Firefox :: Protections UI, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: tgiles, Assigned: jeevikagopal, Mentored)

References

Details

(Whiteboard: [good-first-bug][lang=js])

Attachments

(1 file)

Currently the buttons' text have title casing. The new design styling says button text should be sentence case instead.

For example:

  • "Sign up for Breach Alerts" should be "Sign up for breach alerts"
  • "Manage Passwords" should be "Manage passwords"
  • "Get Mozilla VPN" stays "Get Mozilla VPN" since VPN is a product name and proper noun.

I don't know if new Fluent strings will be required or if there's some kind of capitalization parameter you can add to the string to get these to have updated capitalization.

(In reply to Tim Giles [:tgiles] | back on Nov 29 from comment #0)

I don't know if new Fluent strings will be required or if there's some kind of capitalization parameter you can add to the string to get these to have updated capitalization.

https://mozilla-l10n.github.io/documentation/localization/making_string_changes.html#general-guidelines

If your changes are relevant only for English — for example, to correct a typographical error or to make capitalization consistent — then there is generally no need to update the string ID.

Just update the text, keep the same ID, ignore the linter warnings. We have done plenty of these for MR1 ;-)

Mentor: pbz
Severity: -- → S4
Priority: -- → P3
Whiteboard: [good-first-bug][lang=js]

Hey! I'm an open source newbie and I would like to work on this issue. Can someone guide me?
Thanks!

Flags: needinfo?(pbz)

Hi! You can find the strings that need to be changed in the protections.ftl file, for example: https://searchfox.org/mozilla-central/rev/861fb9abfcaff123aab45f6ac56a0106b116dc14/browser/locales/en-US/browser/protections.ftl#106

From looking at the protections.ftl file, these are the strings that need to be updated (see marked lines): https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/protections.ftl#41,78,80,106-107,164,168,189

I'm not sure if it's currently exposed to users, but we can also update the button text here: https://searchfox.org/mozilla-central/rev/861fb9abfcaff123aab45f6ac56a0106b116dc14/browser/components/protections/content/protections.ftl#13

Changes to that file should be visible if you do an (artifact) build of Firefox and navigate to about:protections. Note that some of the UI may not be visible until you log in to a Firefox account in the browser.
If you haven't built Firefox yet, here are some instructions: https://firefox-source-docs.mozilla.org/setup/index.html
You don't have to do a full build, an artifact build should be sufficient.

I'll assign you to the bug. Please let me know if you have any further questions!

Assignee: nobody → jeevikagopal
Status: NEW → ASSIGNED
Flags: needinfo?(pbz)

hey! I did an artifact build and the changes were reflected as you said!
can you please confirm if I need to update lines 77 & 79? : https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/protections.ftl#77,79

Flags: needinfo?(pbz)

Great! Yes, sorry I forgot to highlight those too. They're buttons so they should follow sentence-case.

Flags: needinfo?(pbz)

Changed the text of buttons to sentence case according to new design styling.

Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/346489d3a36a
Change title-case strings to sentence-case on buttons. r=pbz
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.