1739390 - Remove Lockwise branding

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P1)

Description

[Sergey Galich [:serg]]

• Replace "Firefox Lockwise" with "Passwords" on about:login page.
• Replace "Password Management" with "Passwords" on about:protections page.
• Replace the logo on about:protections and about:login with Firefox logo

Comment 1

[Tim Giles [:tgiles]]

In addition to the scope in Comment #0, we need to do the following:

• Replace the Lockwise favicon on about:logins with the Firefox favicon
• Change the links on the "no logins" screen so that they don't mention Lockwise

As a follow up to this bug we need to:

• Change the no logins illustration itself since it has Lockwise logos on it

Comment 2

[Tim Giles [:tgiles]]

Attachment: Bug 1739390 - Remove Lockwise branding in about:logins. r=sfoster,dimi

Comment 3

[Tim Giles [:tgiles]]

Attachment: Bug 1739390 - Remove Lockwise branding from about:protections. r=pbz!

Depends on D131862

Comment 4

[Sam Foster [:sfoster] (he/him)]

There's been some back and forth about what exactly this should end up looking like. I just reviewed an initial patch from :tgiles, where we replaced the "Lockwise" with the text word "Passwords" in that slot. I think it ends up looking a bit weird - like the image didn't load and that's the alt text. I'm making an executive decision that we should just remove that whole slot, and move the list sort control up on the left - making more space for the list of logins below. This will be consistent with our other about: pages, where we tend to not have any kind of page heading. It also removes the need for a new string.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bcc1debc55f
Remove Lockwise branding in about:logins. r=sfoster,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/ef598c9dc54b
Remove Lockwise branding from about:protections. r=pbz,fluent-reviewers,flod

Comment 6

[Atila Butkovits]

Backed out for causing bc failures with unreferenced files.

Backout link: https://hg.mozilla.org/integration/autoland/rev/950a11eb5af31583c98e138a36380d1ecc0609f8

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1ff449af979d75b31a39df54cd394fc2f9bc068e&selectedTaskRun=FpDdbJNNSQWTNxP3Kqa59g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=359723274&repo=autoland&lineNumber=1795

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70dc036582a4
Remove Lockwise branding in about:logins. r=sfoster,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/7f1d2b6b055b
Remove Lockwise branding from about:protections. r=pbz,fluent-reviewers,flod

Comment 8

[Tim Giles [:tgiles]]

Updated the references to the missing files, should be fixed on this push, fingers crossed.

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/70dc036582a4
https://hg.mozilla.org/mozilla-central/rev/7f1d2b6b055b

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 96.0a1 (Build ID: 20211201214955) on Windows 10 x64, macOS 11.6 and Ubuntu 20.04.

• The “Firefox Lockwise” logo is no longer displayed on the “about:logins” page.
• The “Lockwise” icon from the tab’s title is changed into the “Firefox” logo.
• The links from the “no logins” screen don’t mention “Lockwise” anymore.
• The “Firefox Lockwise” logo is no longer displayed on the “about:protections” page.
• The “Password Manager” title from the “about:protections” page was changed into the “Manage your passwords” title.

@Tim could you please let me know if it is intended that there is no logo for the “Manage your passwords” section on the "about: protections" page? I ask this because it looks weird since the other sections have a logo.

Comment 11

[Tim Giles [:tgiles]]

Thanks for the verification Simona! It is expected that there is no logo for "Manage your passwords" section on "about:protections" (but I do understand that it looks a bit out of place with no logo in that section)

Comment 12

[Simona Rosu [:srosu], Ecosystem QA]

Thank you @Tim for your response. Based on comment 10 and comment 11, I’m marking this issue as Verified Fixed.

Comment 13

[Shane Hughes [:aminomancer]]

Anyone have an opinion on using login.svg instead of the firefox logo for about:logins favicon? I am working on a patch for some of the about pages that don't have favicons so I can add it there. about:logins has an icon already but login.svg would help differentiate it from the many other pages that have the same firefox icon (like the default new tab page), and it's currently only used in a few pretty obscure places.

Comment 14

[Sergey Galich [:serg]]

(In reply to Shane Hughes [:aminomancer] from comment #13)

Anyone have an opinion on using login.svg instead of the firefox logo for about:logins favicon? I am working on a patch for some of the about pages that don't have favicons so I can add it there. about:logins has an icon already but login.svg would help differentiate it from the many other pages that have the same firefox icon (like the default new tab page), and it's currently only used in a few pretty obscure places.

We'd prefer to keep default Firefox icon there for now because about:logins page is a part of Firefox itself and not being branded yet.

Comment 15

[Shane Hughes [:aminomancer]]

(In reply to Sergey Galich from comment #14)

We'd prefer to keep default Firefox icon there for now because about:logins page is a part of Firefox itself and not being branded yet.

I agree it definitely shouldn't use a lockwise icon, but all the about pages are part of Firefox, and several of the major ones have more specific vector icons, like about:preferences, about:addons, about:debugging, and about:profiling. I guess that could be seen as a defect, but the icons help to differentiate the pages and illustrate their purpose. So I honed in on the key icon login.svg since it perfectly illustrates the purpose of about:logins

Comment 16

[Sergey Galich [:serg]]

Hmm, you are right, other pages already have some nice icons. Personally I'm not thrilled with that login.svg graphics, but yeah, it kind of resembles what we do there. I withdraw my protest :)

Comment 17

[Shane Hughes [:aminomancer]]

I kinda liked the pre-proton login.svg better, personally. I like this one for about:logins too. I would look into making a new one but it seems like new icons aren't welcome since refreshing them in the future will create additional work for illustrators.

Comment 18

[Sergey Galich [:serg]]

I hope to get some design attention to whole about:logins and when we get it, we definitely should look into making better icons.