174283 - Xft font prefs should list fontconfig generic families

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

As noted in bug 126919, fontconfig has 3 generic families, "serif",
"sans-serif", and "monospace".  These should probably be listed in Edit |
Preferences | Appearance | Fonts.

I just hacked up a little code that does this into the font enumerator.  This
raises some interesting questions:
 * Should we list all 3 for every generic, or should we only list "appropriate"
ones.  (This brings up another question -- is there a way the fontconfig APIs
can tell us whether a font is serif, sans-serif, or monospace, like the font
APIs do on Windows (I think).  It seems somewhat inconsistent to limit the
choice of the generics but not limit the choice for anything else.)
 * Are "serif", "sans-serif", and "monospace" exactly the right things to call
them?  I tested them and they seem to work right.  I also listed them at the
beginning.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch to list only appropriate generic fonts

Comment 2

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks!