1742918 - FF94 has broken Opera GX Theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[RagglenLove]

Attachment: Screenshot_2021-11-25_09-46-24.jpg

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Create a new test profile.

2. Install Opera GX by Seburo

3. Right click on the urlbar to bring out the context menu, the menu's color is faded and the fonts are hard to see.

Actual results:

Right click on the urlbar to bring out the context menu, the menu's color is faded and the fonts are hard to see.

Expected results:

The context menu on the urlbar should be similar to the context menu on the tab bar, as you can see from the screenshot, the context menu on the tab bar is of normal color and the fonts are seen and can be easily read.

Please note that this wasn't like this in Firefox 93.0.

Comment 1

[RagglenLove]

Additional notes

I'm running Firefox 94.0 on Xubuntu 20.04.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Text and Fonts' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Can you attach your about:support? What's your GTK theme? Does this work on latest Nightly? (It works for me, context menus are ok here). Though they're white when they're supposed to be dark, so I'll take a look at that.

Comment 4

[RagglenLove]

Attachment: about:support.txt

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Can you attach your about:support?

Done.

What's your GTK theme?

Windows-10-Dark

Does this work on latest Nightly? (It works for me, context menus are ok here). Though they're white when they're supposed to be dark, so I'll take a look at that.

I do not know how to install Firefox Nightly on Xubuntu 20.04. Is there a flatpak of Firefox Nightly available?

Comment 5

[RagglenLove]

Attachment: Screenshot_2021-11-26_08-36-13.jpg

This bug doesn't just affect Opera GX by Seburo, it also affects other similar themes, like Game Red with Highlighted Tab by Twijg.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

(In reply to RagglenLove from comment #4)

I do not know how to install Firefox Nightly on Xubuntu 20.04. Is there a flatpak of Firefox Nightly available?

Just download it from the link above, extract it somewhere and run it. It should create its own profile so shouldn't mess with your system :)

Comment 7

[RagglenLove]

Attachment: Screenshot_2021-11-26_10-19-09.jpg

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

(In reply to RagglenLove from comment #4)

I do not know how to install Firefox Nightly on Xubuntu 20.04. Is there a flatpak of Firefox Nightly available?

Just download it from the link above, extract it somewhere and run it. It should create its own profile so shouldn't mess with your system :)

Done.

On the screenshot, the context menu of the urlbar is white with black font and also Firefox Nightly doesn't follow my system's theme, as you can see from the Close, Minimize and Maximize buttons.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:hiro, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

I think I can reproduce this issue on my Ubuntu 20.04. Moving to the same component as bug 1743010.

Comment 10

[Dão Gottwald [:dao]]

Not sure if there's anything left to do here after bug 1743010.

Comment 11

[Negritas Sergiu, Desktop QA]

Hello! I have managed to reproduce the issue with the STR provided in the description and managed to find a regression range for this issue using Ubuntu 20.

Here is the pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d47ffc49daff50121bfbb75ac919877f7120c750&tochange=76a9658042105f5813d39483c02e3bd4983f108d

Here is a more larger pushlog if it's needed:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73f23b9a5cf6f8531bc5dccdbd5d8ffad1dd632e&tochange=92641110e5c9cc095140f25cb4c79e5a15a72a64

Comment 12

[Dão Gottwald [:dao]]

Marking this as S3, assuming this isn't an issue for a large number of themes.

Harry, could you please look into this?

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1732430

Comment 14

[Harry Twyford]

Emilio or Dao, I'm going to need a bit of help with this one. I don't know much anything about Linux system themes or Linux context menus. The regressing patch sets color-scheme on a few elements based on whether a lwtheme is applied. I imagine the relevant affected element is .popup-notification-body, changed here. I thought that selector was just for doorhangers, but maybe its used for Linux context menus as well?

With bug 1743010 fixed, the theme in comment 0 should present as a dark theme, so we should be using color-scheme: dark. This seems correct. From there, I really know know how the text would be dimmer for some themes. My guess is that since "Opera GX" registered as a light theme when this bug was filed, there was a light context menu but the system theme applied some filter to make it dark. This filter then made the text contrast incorrect? That might be way off...

I'm happy to fix this, but some more context about Linux system themes/context menus would be helpful!

Comment 15

[Emilio Cobos Álvarez (:emilio)]

So, I think there were two bugs here. One is that we detected that the theme was dark instead of light and I fixed in bug 1743010. The other is that we still think that the text color of the urlbar is "dark" and thus we end up with color-scheme: light here, and that inherits to the menupopup in the textbox-contextmenu here.

So, the first one is fixed and I think it was the biggest issue.

The second one is not, and I don't think that's a huge deal, honestly. As per the screenshot in comment 7, the context menu is light, somewhat unexpectedly, but it's pretty much working ~as expected. This is not Linux-specific, mind you. The same should happen in macOS as well.

We could drop a .textbox-contextmenu { color-scheme: initial } or so so that Linux and macOS follow the default system rendering... But if we're to change anything here I'd rather tweak the dark-theme detection instead, to not consider the text in the urlbar "dark" given we have such a dark background.

Comment 16

[Harry Twyford]

Thank you for the explanation!

(In reply to Emilio Cobos Álvarez (:emilio) from comment #15)

The same should happen in macOS as well.

Hm, I'm not seeing it... as far as I can tell, macOS context menus only follow the system theme. I get dark context menus in Light, Dark, and Opera GX when in system Dark mode and light context menus in those three themes when in system Light mode.

Comment 17

[Emilio Cobos Álvarez (:emilio)]

(In reply to Harry Twyford [:harry] from comment #16)

Hm, I'm not seeing it... as far as I can tell, macOS context menus only follow the system theme. I get dark context menus in Light, Dark, and Opera GX when in system Dark mode and light context menus in those three themes when in system Light mode.

Ah, shoot, you're right, that's because of widget.macos.native-context-menus=true. Probably we should make them follow color-scheme for consistency with all other popups.

Comment 18

[Harry Twyford]

Attachment: Bug 1742918 - Consider background color when setting brightext popups and toolbar fields. r?#desktop-theme-reviewers,emilio

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85a1717fd579
Consider background color when setting brightext popups and toolbar fields. r=emilio,desktop-theme-reviewers,dao

Comment 20

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/85a1717fd579

Comment 21

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue using an affected Nightly build 96.0a1 from 2021-11-24, on Ubuntu 20.04.
Verified fixed on 97.0b5 (20220118185733) on Ubuntu 20.04 and macOS 10.14.

On Windows 10 x64, the context menu from the URL bar is white with black font (as per comment 7), even if the system theme is Light or Dark. Is this expected?

Comment 22

[Emilio Cobos Álvarez (:emilio)]

You mean the other way around right, it should have a dark background. If so, yes, it's expected.

Comment 23

[Giorgia Nichita, Release Desktop QA]

No, on Windows all the backgrounds of the context menus are white (URL bar, Address bar and Bookmarks Toolbar).

Comment 24

[Giorgia Nichita, Release Desktop QA]

Attachment: OperaGXcontextmenus.png

I attached an image with the behavior. Thank you!

Comment 25

[Giorgia Nichita, Release Desktop QA]

I will close this as verified fixed because even if this issue is still reproducible on Win 10, Firefox 97 it is not reproducible on Firefox 117.0 and the latest Nightly 118.a01.

Verified as fixed on Firefox 117.0 (20230821145345) and Nightly 118.0a1 (20230824035406) across the following platforms: Win 10 x64, Ubuntu 20.04 and macOS 10.15.