1732430 - [Monochromatic Themes] The user and password field in the Save login panel has a black backgroud while using Bold and Balanced themes

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Oana Botisan, Desktop QA]

Attachment: Screenshot 2021-09-24 at 10.40.57.png

Affected versions

• Firefox 94.0a1

Affected platforms

• macOS 10.15
• Ubuntu 18.04 x64

Preconditions

• browser.theme.temporary.monochromatic.enabled = true
• Select one the Grafitti Balanced theme.

Steps to reproduce

1. Go to Facebook and write a set on credential in the user and password field.
2. Click on key icon from the URL bar.

Expected result

• The background color for the user and password fields is white (for Balanced themes) or a darker grey color (for Bold themes).

Actual result

• The background color for the user and password fields is black.

Regression range

• Not a regression.

Additional notes

• All the Bold and Balanced themes are effected except Elemental Balanced and Cheers Balanced.
• There are no other elements that are black in the themes design.
• This issue is reproducing inside the Bookmark panel as well.
• Even when Dark theme is enabled the fields are not black, are a darker grey.

Comment 1

[Harry Twyford]

I suspect this is the result of us forcing white backgrounds on a brightext theme. We are still using dark mode system colors, and the two conflict.

Comment 2

[Harry Twyford]

Attachment: Bug 1732430 - Use theme-aware system colors in panel inputs. r?dao!

Comment 3

[Harry Twyford]

[Tracking Requested - why for this release]:
Contrast issue in the new themes. It has a CSS-only fix that is already close to landing.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76a965804210
Use theme-aware system colors in panel inputs. r=dao

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/76a965804210

Comment 6

[Harry Twyford]

Comment on attachment 9243561 [details]
Bug 1732430 - Use theme-aware system colors in panel inputs. r?dao!

Beta/Release Uplift Approval Request

• User impact if declined: Users will see the wrong color inputs in some panels while using the new themes. They would see dark inputs in a light panel or vice versa. This is a pre-existing issue made more visible by the new themes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS-only fix.
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9243561 [details]
Bug 1732430 - Use theme-aware system colors in panel inputs. r?dao!

Approved for 94.0b2.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/af1d667bdfa3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out from Beta due to bug 1734655. We can re-land when there's an upliftable fix ready for that bug also.
https://hg.mozilla.org/releases/mozilla-beta/rev/3d93aa395045

Comment 10

[Oana Botisan, Desktop QA]

I can still reproduce this issue while using macOS 10.15 and Windows 10 x64 on Firefox 94.0b4.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Re-landing this for 94.0b5 alongside bug 1733968 and bug 1734716. Please be sure to test the various bugs associated with this issue as part of verifying the fix.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9919eef5e6bd

Comment 13

[Oana Botisan, Desktop QA]

Verified the fix using Firefox 94.0b5 and Nightly 95.0a1 on macOS 10.15 and Ubuntu 18.04 x64. The issue is not reproducing anymore.