1743139 - [win] Next button focus outline overlaps the Back button inside profile creation window

Status: NEW

(Toolkit :: Themes, defect, P5)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: profile_window

Affected versions

• 96.0a1 (20211126093927)

Affected platforms

• Windows10 x64

Steps to reproduce

1. Open Firefox and about:profiles.
2. Click on Create new profile and observe the buttons.

Expected result

• Buttons are displayed as expected.

Actual result

• Focus from the Next button is covering a part of the Back button.

Regression range

• I managed to find two pushlogs here that changed the Back/ Next buttons.

• First one changed the position of the two buttons making them stick one to another:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef7b596bb385f46280eb1492009bf8fb541e17db&tochange=b94153cca1f7d677fbbcc1a0d4923d81ddec8958

• the Second pushlog adds an outline:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c2bbc546c08d381b9bddd0e3228d6c276b109bd0&tochange=d5b7bad1db7901f87d008cc675b49fc1afb4c890

• I will set bug 1741359 as the regressor, please feel free to change it if you feel otherwise.

Notes

• Screenshot attached.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1741359

Comment 2

[Dianna Smith [:diannaS]]

Emilio, can you take a look at this? It is marked as regressed from bug 1741359. thank you!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This is the expected rendering given the position of the buttons. Same happens in HTML buttons like: data:text/html,<button>A</button><button>B</button>.

If we want to add some spacing between those buttons that's fine, but it seems cosmetic at best (and Dão has already prioritized this above).