1741359 - Dark theme specific highlight focus is missing from some of the Restart Nightly/Firefox panels

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Anca Soncutean, Desktop QA]

Attachment: screenshoot issue.png

Affected versions

• 94.0.1
• 95.0b7
• 96.0a1

Affected platforms

• Windows 10

Steps to reproduce

1. Go to about:preferences#privacy
2. Select “Never remember history” from the “History” section
3. Navigate the panel using the Tab key

Expected result

• The highlight focus has the dark theme specific color

Actual result

• The highlight focus is just a dotted white one

Regression range

• Last good revision: 1ff04e10cd2318b494c0f05777cd80291289d127
• First bad revision: d39b23efefe7e7d89d8dfd0ba188ad6af2b0a9ed
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1ff04e10cd2318b494c0f05777cd80291289d127&tochange=d39b23efefe7e7d89d8dfd0ba188ad6af2b0a9ed
• Regressor: 1733569

Other notes

• Reproducible when attempting to enabled features from Nightly Experiments tab
• Not reproducible on restart prompts from about:support

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733569

Comment 2

[Emilio Cobos Álvarez (:emilio)]

This is as per this code so it's sorta expected I believe?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

The dialogs in about:support are tab-modal, these are browser-modal and have different styles (comment 2).

However I guess it's a bit nicer to use the native outline when we're using the dark theme.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1741359 - Use auto outline for Windows buttons in dark mode. r=#desktop-theme-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5b7bad1db79
Use auto outline for Windows buttons in dark mode. r=desktop-theme-reviewers,dao

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d5b7bad1db79

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Probably not, it's a minor cosmetic fix, but if someone disagrees then please be my guest :-)

Comment 9

[Virgil Sangerean]

Validated on 96.0 Firefox on Windows 10.