1743199 - Attachment icon is barely visible when message is higlighted on Windows 7 with windows classic theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[stephen]

Attachment: Capture.JPG

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

I use windows 7 and the "windows classique" theme
Then I select a message in the message panel, containing an attached file. Therefore, there is a paper-clip icon in the column "attachment".

Actual results:

The message background is highlighted in dark blue and the message subject appears in white but the paper-clip icon remains black. So this icon is barely visible

I tried to adapt my theme with the following CSS code in a userchrome.CSS :
#threadTree treechildren::-moz-tree-image(attachmentCol, attach, focus, selected) {
color: white !important; }
Even with this CSS code, the attachment icon remains black

Expected results:

The message background is highlighted in dark blue and the message subject appears in white but the paper-clip icon should appear white also.
OR
The default color used in Thunderbird theme to highlight messages should be less dark (as it is in the default Windows 7 theme) to make the attachment icon more visible.
AND
The following CSS code in a userchrome.css should make the attachment icon appear white :
#threadTree treechildren::-moz-tree-image(attachmentCol, attach, focus, selected) {
color: white !important; }

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1743199-classic-tree-color.patch

This is only visible on Windows 7 Classic and High Contrast and not on Windows 10.

There was a rule missing for the tree-image and tree-twisty when selected and focused.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9252721 [details] [diff] [review]
1743199-classic-tree-color.patch

Review of attachment 9252721 [details] [diff] [review]:
-----------------------------------------------------------------

I'll trust you on this as I can only partially simulate this scenario but not test it in real life.

Comment 3

[stephen]

I implemented the patch in my messenger.css and can confirm it works fine

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ec0c66351cd2
[Windows 7 Classic] Set the color for selected and focused tree-image and tree-twisty. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1743199-classic-tree-color-ESR.patch

[Approval Request Comment]
User impact if declined: on Windows 7 Classic the icons on selected focused treechildrens are barely visible
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9253084 [details] [diff] [review]
1743199-classic-tree-color-ESR.patch

[Triage Comment]
Approved for esr91

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/ce23e9df55c3

Comment 8

[stephen]

Hi,
There is one remaining issue : The attachment icon becomes black when the e-mail item is selected but when the focus is not on this item. For instance : select an e-mail, then click on inbox in the left panel.

Comment 9

[Richard Marti (:Paenglab)]

I see no issue. Please file a new bug with exact informations about your Windows theme/colour setting and TB theme. Also please add a screenshot which shows your issue. Also on what TB version do you see this?

Comment 10

[stephen]

Hi,
the issue "attachment icon is not visible when a message is selected because icon is black and selected messages' background color are dark blue in Windows 7 classic theme

Comment 11

[Alessandro Castellani [:aleca]]

Stephen, don't reopen a closed bug! That's not proper bugzilla etiquette.

As Richard suggested, please open a new bug and attach a screenshot, and write as much info as you can so we can try to reproduce.