Closed Bug 1743411 Opened 10 months ago Closed 10 months ago

Tree highlight color too invisible with [lwt-default-theme-in-dark-mode]

Categories

(Thunderbird :: Theme, task)

Tracking

(thunderbird_esr91+ fixed)

RESOLVED FIXED
96 Branch
Tracking Status
thunderbird_esr91 + fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

With [lwt-default-theme-in-dark-mode] the tree highlight is grey instead of a Highlight colour like blue.

How about this?

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9252864 - Flags: review?(alessandro)
Comment on attachment 9252864 [details] [diff] [review]
1743411-dark-theme-tree-highlight.patch

Review of attachment 9252864 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #9252864 - Flags: review?(alessandro) → review+
Target Milestone: --- → 96 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/b634c1708485
Set a tree highlight color for the [lwt-default-theme-in-dark-mode]. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED

[Approval Request Comment]
User impact if declined: not well visible highlighted treeitem with system dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low, only one CSS variable added

Attachment #9253758 - Flags: approval-comm-esr91?

Comment on attachment 9253758 [details] [diff] [review]
1743411-dark-theme-tree-highlight-ESR.patch

[Triage Comment]
Approved for esr91

Attachment #9253758 - Flags: approval-comm-esr91? → approval-comm-esr91+
You need to log in before you can comment on or make changes to this bug.