1743411 - Tree highlight color too invisible with [lwt-default-theme-in-dark-mode]

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

With [lwt-default-theme-in-dark-mode] the tree highlight is grey instead of a Highlight colour like blue.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1743411-dark-theme-tree-highlight.patch

How about this?

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9252864 [details] [diff] [review]
1743411-dark-theme-tree-highlight.patch

Review of attachment 9252864 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b634c1708485
Set a tree highlight color for the [lwt-default-theme-in-dark-mode]. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1743411-dark-theme-tree-highlight-ESR.patch

[Approval Request Comment]
User impact if declined: not well visible highlighted treeitem with system dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low, only one CSS variable added

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9253758 [details] [diff] [review]
1743411-dark-theme-tree-highlight-ESR.patch

[Triage Comment]
Approved for esr91

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/b77a52c59fd1