Closed Bug 1743440 Opened 3 years ago Closed 3 years ago

Calendar uses a light color in system dark theme on Linux

Categories

(Thunderbird :: Theme, defect)

Thunderbird 96
Desktop
Linux
defect

Tracking

(thunderbird_esr91 unaffected, thunderbird95 unaffected)

RESOLVED FIXED
96 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird95 --- unaffected

People

(Reporter: sdk, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image tb-calendar-white.png

AB:

The big calendar inside the calendar tab uses the light theme colors instead of the dark theme colors when using the system theme

EB:

It should use the colors from the system dark theme.

Additional information:

https://hg.mozilla.org/comm-central/pushloghtml?fromchange=0295d55c1fdea60192d6518ec9fe23a8664f1966&tochange=f51d369901e3087d413171aeb434838c7414454e

Flags: needinfo?(mkmelin+mozilla)

I can reproduce using the Adwaita-dark theme on Fedora 35 Workstation, Gnome 41 desktop and the Thunderbird System theme.

Enabling "Optimize colors for accessibility" makes it dark again, but that should not be needed.

Flags: needinfo?(mkmelin+mozilla)
Keywords: regression
Regressed by: 1740652

I'm sure I've tested bug 1740652 on Linux with system dark theme too. :-(

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9252903 - Flags: review?(alessandro)
Comment on attachment 9252903 [details] [diff] [review] 1743440-calendar-dark-on-Linux.patch Review of attachment 9252903 [details] [diff] [review]: ----------------------------------------------------------------- I remember testing this scenario as well. We really need to implement some tests to be sure these things don't keep breaking.
Attachment #9252903 - Flags: review?(alessandro) → review+
Target Milestone: --- → 96 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4fec081d6966
Remove the :-moz-lwtheme-brighttext in calendar-views.css to work also with the Linux dark themes. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: