Closed Bug 1743925 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 31822 - Unify template to create canvas and offscreencanvas tests

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 31822 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31822
Details from upstream follow.

Yi Xu <yiyix@chromium.org> wrote:

Unify template to create canvas and offscreencanvas tests

The typical way to add tests for canvas and offscreencanvas is as
following:

  • write the test in yaml/element (create the test for canvas)
  • copy the the test to yaml/offscreencanvas
  • add t.done() to the end of test (create the test for offscreencanvas)

This is because the API for canvas and offscreencanvas are mostly the
same.

This cl updates templates and gentestutils to allow the framework of
generate canvas and offscreencanvas test from test.

I removed both yaml/element/color_space.yaml and
yaml/offscreencanvas/color_space.yaml and add yaml_new/color_space.yaml.
Now the yaml_new/color_space.yaml genrates the same results as before.

Note that you it's possible to add test for a particular canvas type
by using canvasType as keyword.

Bug: 1275750
Change-Id: I6bf48ec3081f5fe3669bf585f92b39a712045c6b
Reviewed-on: https://chromium-review.googlesource.com/3307080
WPT-Export-Revision: b787da3f2cf779dcf3afe3ca437ab2401f8c2a13

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Attached file Notable wpt changes
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 2723 tests and 1 subtests ## Status Summary ### Firefox OK : 2723 PASS : 896 FAIL : 1827 ### Chrome OK : 2721 PASS : 2671 FAIL : 52 ERROR : 2 ### Safari OK : 2722 PASS : 882 FAIL : 1840 TIMEOUT: 1 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=f22c5eea45715847efb373005608d43940c8e89c&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=f22c5eea45715847efb373005608d43940c8e89c&label=pr_base) ## Details ### Firefox-only Failures /html/canvas/element/compositing/2d.composite.operation.clear.html Canvas test: 2d.composite.operation.clear: FAIL linked bug:Bug 1646754 /html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.reload.html Canvas test: 2d.drawImage.incomplete.reload: FAIL linked bug:Bug 1646754 /html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.boundingBox.direction.html Measurement should follow text direction: FAIL linked bug:Bug 1700289 /html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.fontBoundingBox.ahem.html Testing fontBoundingBox for font ahem: FAIL linked bug:Bug 1666598 /html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.fontBoundingBox.html Testing fontBoundingBox: FAIL linked bug:Bug 1646754 /html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.reload.html Canvas test: 2d.pattern.image.incomplete.reload: FAIL linked bug:Bug 1646754 /html/canvas/element/text-styles/2d.text.font.parse.complex.html Canvas test: 2d.text.font.parse.complex: FAIL linked bug:Bug 1646754 /html/canvas/element/text-styles/2d.text.font.parse.invalid.html Canvas test: 2d.text.font.parse.invalid: FAIL linked bug:Bug 1691665 /html/canvas/element/text-styles/2d.text.font.parse.size.percentage.default.html Canvas test: 2d.text.font.parse.size.percentage.default: FAIL linked bug:Bug 1646754 /html/canvas/element/text-styles/2d.text.font.parse.size.percentage.html Canvas test: 2d.text.font.parse.size.percentage: FAIL linked bug:Bug 1646754 /html/canvas/element/text-styles/2d.text.font.parse.system.html System fonts must be computed to explicit values: FAIL linked bug:Bug 1646754 /html/canvas/element/text-styles/2d.text.font.relative_size.html Canvas test: 2d.text.font.relative_size: FAIL linked bug:Bug 1646754 (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c66843d8f338 [wpt PR 31822] - Unify template to create canvas and offscreencanvas tests, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: