1743929 - Port bug 1715892 to Thunderbird - Unify the intl/locale/DateTimeFormat API into the intl/components/DateTimeFormat

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Rachel Martin]

Attachment: port-1715892.patch

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

You will need this soon. Tweak as you deem fit.

Comment 1

[Rachel Martin]

Comment on attachment 9253337 [details] [diff] [review]
port-1715892.patch

Please note the attached patch.

Comment 2

[Rachel Martin]

Attachment: port-1715892.patch

This time without the unwanted comment changes :-(

Comment 3

[Rachel Martin]

In the view code, the kDateFormatNone case is missing, so for today you won't get anything. Please add. BTW, all untested.

Comment 4

[Geoff Lankow (:darktrojan)]

Looks good to me.

(In reply to Rachel Martin from comment #3)

In the view code, the kDateFormatNone case is missing, so for today you won't get anything. Please add.

Any particular reason why not? You got 99% of the way there…

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1743929-date-format.diff

Comment 6

[Rachel Martin]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

Any particular reason why not? You got 99% of the way there…

You misunderstood.
In the view code, the kDateFormatNone case is missing, so for today you won't get anything.
This was meant to mean:
In the view code, the kDateFormatNone case is missing, so for the display of today's date/time you won't get anything displayed.
Also we didn't test it at all. So thanks for adding and testing.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f57258e2c14f
Port bug 1715892 - Unify the intl/locale/DateTimeFormat API into the intl/components/DateTimeFormat. r=darktrojan