1744581 - test_fission_autostart.py being accidentally skipped in all configurations

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

The test_fission_autostart.py test is configured to automatically pass with a success on platforms where the initial preference state isn't configured to be the default. It appears that at some point when preparing for enabling fission by default, we explicitly used a user preference to disable fission.autostart in all configurations, and caused the check in https://searchfox.org/mozilla-central/rev/6a7c3a1eda4ebb8f9c13779dbbf5eff15bacf8ed/toolkit/xre/test/marionette/test_fission_autostart.py#89-92 to always return True, skipping all of the tests.

Simply removing the check will not work, as having the pref as required prevents us from changing it's value throughout the test, breaking it.

Comment 1

[Andrew Halberstadt [:ahal]]

Thanks for noticing this, the pref started being explicitly set here:
https://hg.mozilla.org/integration/autoland/rev/edd0ea14fcca

I'm not too clear on the intent of these tests, so redirecting to whimboo who hopefully has some ideas.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I reviewed a patch for that from Nika some days ago. I assume the wrong bug number was referenced in the commit message so that it doesn't appear on this bug?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Yes, I am fixing this in part 1 of bug 1732358

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1736859

Comment 5

[Chris Peterson [:cpeterson]]

Assigning to Nika because she is fixing this in bug 1732358 part 1.

We won't need to uplift this test fix to Beta 96.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Chris Peterson [:cpeterson] from comment #5)

Assigning to Nika because she is fixing this in bug 1732358 part 1.

I'm a bit confused. What's left in this bug after bug 1732358 is landed?

We won't need to uplift this test fix to Beta 96.

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Fixed by bug 1732358