1744644 - Cleanup commented out usage of kIsLibaomAv1{En|De}coderSupported in third_party/libwebrtc/media/engine/internal_{en|de}coder_factory.cc

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

In ef548d7758c7 Disable creating av1 encoder and decoder third_party/libwebrtc/media/engine/internal_decoder_factory.cc kIsLibaomAv1DecoderSupported usage is commented out.
In third_party/libwebrtc/media/engine/internal_encoder_factory.cc kIsLibaomAv1EncoderSupported usage is commented out.

If we properly set enable_libaom here it will instead us
libaom_av1_decoder_absent.cc and libaom_av1_encoder_absent.cc. Each of these returns null, preserving the current behavior of internal_{en|de}coder_factory.cc.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1744644 - regenerate build files in third_party/libwebrtc as baseline. r?ng!

For some reason, third_party/libwebrtc/rtc_base/timeutils_gn/moz.build was
in an odd state after our final merge where each of the platforms contained
DEFINES["WEBRTC_EXCLUDE_SYSTEM_TIME"] = True
instead of having that define at the top level across all platforms. After
re-running the generation on each platform (macOS/Linux/Win), all platforms
ended with this file in the same state with the define at the top.

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1744644 - restore 2 files to match moz_libwebrtc versions. r?ng!

This restores the contents of these 2 files to match moz_libwebrtc
versions. The changes we're reverting were made simply to help
get the project compiling, but there is a more official way to
accomplish the same thing (see the next patch).

Depends on D133405

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1744644 - set enable_liboam to false for mozilla builds. r?ng!

This change results in using libaom_av1_decoder_absent.cc and
libaom_av1_encoder_absent.cc.

When using the libaom_av1_{en|de}coder_absent.cc files, we don't
need scalable_video_controller as a dependency.

Both of these changes should be upstreamable.

Depends on D133406

Comment 4

[Michael Froman [:mjf]]

Attachment: Bug 1744644 - json file updates. r?ng!

Depends on D133407

Comment 5

[Michael Froman [:mjf]]

Attachment: Bug 1744644 - moz.build updates. r?ng!

Depends on D133408

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eed9b1dfa1d
regenerate build files in third_party/libwebrtc as baseline. r=ng
https://hg.mozilla.org/integration/autoland/rev/1c31dce53dff
restore 2 files to match moz_libwebrtc versions. r=ng
https://hg.mozilla.org/integration/autoland/rev/4424fcfae2bf
set enable_liboam to false for mozilla builds. r=ng
https://hg.mozilla.org/integration/autoland/rev/724151aa470d
json file updates. r=ng
https://hg.mozilla.org/integration/autoland/rev/38c455e19287
moz.build updates. r=ng

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6eed9b1dfa1d
https://hg.mozilla.org/mozilla-central/rev/1c31dce53dff
https://hg.mozilla.org/mozilla-central/rev/4424fcfae2bf
https://hg.mozilla.org/mozilla-central/rev/724151aa470d
https://hg.mozilla.org/mozilla-central/rev/38c455e19287