1747862 - regenerate webrtc json/moz.build files for openbsd support after bug #1744644

Status: VERIFIED FIXED

(Core :: WebRTC, defect, P2)

Description

[Landry Breuil (:gaston)]

cf https://bugzilla.mozilla.org/show_bug.cgi?id=1747196#c14 , openbsd support was readded in bug #1654448 but bug #1744644 broke it.

working on it, hoping to get something commited for 97.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1744644

Comment 2

[Landry Breuil (:gaston)]

Attachment: regen openbsd json files

Comment 3

[Landry Breuil (:gaston)]

Attachment: regen moz.build files

i've been able to link libxu l (from a previously failing objdir) with those and https://hg.mozilla.org/integration/autoland/rev/432387e4879b, redoing a clobber build overnight to confirm but those changes are mechanical.

Comment 4

[Landry Breuil (:gaston)]

m-c building from a clean objdir with those patches, horray :)

Comment 5

[Michael Froman [:mjf]]

Comment on attachment 9257049 [details] [diff] [review]
regen openbsd json files

This looks good - basically when Bug 1654448 landed, those patches should have been rebased onto tip (and regen'd) before landing. This is what would have happened if the rebase/regen had been done.

Comment 6

[Michael Froman [:mjf]]

Comment on attachment 9257050 [details] [diff] [review]
regen moz.build files

This looks good - basically when Bug 1654448 landed, those patches should have been rebased onto tip (and regen'd) before landing. This is what would have happened if the rebase/regen had been done.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/436f3c0ae63b
regenerate webrtc JSON files  for openbsd support after bug 1744644. r=mjf
https://hg.mozilla.org/integration/autoland/rev/3607c4937e84
regenerate webrtc moz.build files after bug 1744644. r=mjf

Comment 8

[Landry Breuil (:gaston)]

(In reply to Michael Froman [:mjf] from comment #5)

Comment on attachment 9257049 [details] [diff] [review]
regen openbsd json files

This looks good - basically when Bug 1654448 landed, those patches should have been rebased onto tip (and regen'd) before landing. This is what would have happened if the rebase/regen had been done.

well, you cant really expect everyone/external contributors not working daily on mozilla-central to keep up with what happens in it :)

thanks for the landing ! once it merged to m-c i'll make sure that the tree builds for us :)

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/436f3c0ae63b
https://hg.mozilla.org/mozilla-central/rev/3607c4937e84

Comment 10

[Landry Breuil (:gaston)]

m-c from https://hg.mozilla.org/mozilla-central/rev/e633666f5eb7 built fine on openbsd, thanks !