1744772 - the default avatar on the right corner of the "about:logins" page cannot be displayed correctly

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[thinking962]

Attachment: Screen Recording 2021-12-07 at 11.23.20 PM.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36

Steps to reproduce:

[Affected versions]:

• 94.0.2, 95.0

[Affected Platforms]:

• macOS 10.13.6
• macOS 10.15.7

[Prerequisites]:

• Have a valid FxA account with the default avatar.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Observe the default avatar on the right corner of the "about:logins" page.

Actual results:

There is impurity on the default avatar.

Expected results:

The default avatar is displayed correctly.

Comment 1

[Tim Giles [:tgiles]]

This is due to the way we handle the FxA account avatar. We use background-image in a way so that if there is no loaded --avatar-url we fallback to the generic icon. However it appears we end up loading both images in this case causing the issue seen in Comment #0.

I guess we'll need to determine another way of loading the non-generic FxA avatar and the generic FxA avatar that doesn't involve using background-image. Maybe we could use --avatar-url to set the generic logo and the non-generic logo so that we don't need to have this fallback pattern in the background-image selector.

Comment 2

[thinking962]

I also check it in the dark mode. This problem also exists in that mode.

Comment 4

[Tim Giles [:tgiles]]

Attachment: Bug 1744772 - Fix default avatar from appearing on top of initial character avatar. r=sgalich

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c72dfea95ac8
Fix default avatar from appearing on top of initial character avatar. r=sgalich

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c72dfea95ac8

Comment 7

[Alice Varro [avarro], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Nightly 101.0a1 (Build ID - 20220501190841) on Windows 10, macOS 12.3.1 and Linux Mint 20.2. The FxA default avatar is correctly displayed on the top-right corner on the “about:logins” page.