1744809 - Remove boilerplate in IOUtils frontend methods

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, enhancement, P1)

Description

[Barret Rennie [:barret] (they/them)]

IOUtils frontend methods all look like:

IOUtils::Method(GlobalObject& aGlobal, ...) {
  MOZ_DIAGNOSTIC_ASSERT(XRE_IsParentProcess());
  RefPtr<Promise> promise = CreateJSPromise(aGlobal);
  if (!promise) {
    return nullptr;
  }

  if (auto state = GetState()) {
    // Do actual unique work
  } else {
    RejectShuttingDown(promise);
  }
  return promise.forget();
}

which is a lot of boilerplate per method. We should remove this boilerplate if we can to make maintenance easier.

Comment 1

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1744809 - Reduce boilerplate in IOUtils frontend methods r?nika

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbbcea46c9d9
Reduce boilerplate in IOUtils frontend methods r=nika

Comment 3

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1744809, Bug 1744316) for causing xpcshell failures on marAppApplyDirLockedStageFailure_win.js.
Backout link
Push with failures
Failure Log

Comment 4

[Barret Rennie [:barret] (they/them)]

The failure was in the other patch. Going to land them separately.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fd7e5380524
Reduce boilerplate in IOUtils frontend methods r=nika

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5fd7e5380524