1746095 - Crash in [@ mozilla::dom::HTMLCanvasElementObserver::Observe]

Status: RESOLVED FIXED

(Core :: Canvas: 2D, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

I didn't implement handling memory pressure events.

Crash report: https://crash-stats.mozilla.org/report/index/8fe8948a-7d95-40e8-9aab-535d70211215

MOZ_CRASH Reason: MOZ_CRASH(todo)

Top 10 frames of crashing thread:

0 libxul.so mozilla::dom::HTMLCanvasElementObserver::Observe dom/html/HTMLCanvasElement.cpp:324
1 libxul.so nsObserverList::NotifyObservers xpcom/ds/nsObserverList.cpp:70
2 libxul.so nsObserverService::NotifyObservers xpcom/ds/nsObserverService.cpp:292
3 libxul.so mozilla::dom::ContentChild::RecvFlushMemory dom/ipc/ContentChild.cpp:2588
4 libxul.so mozilla::dom::PContentChild::OnMessageReceived ipc/ipdl/PContentChild.cpp:10458
5 libxul.so mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:1968
6 libxul.so mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:771
7 libxul.so NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:467
8 libxul.so mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:85
9 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:306

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1746095 - Avoid crashing when we get memory pressure events with OffscreenCanvas.

We will implement this properly in bug 1746260, but for now, let's spare
users with OffscreenCanvas turned on, who have low memory, a content
process crash. Handling it is somewhat complicated because we need to
shuttle over the message to the worker.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cb4a2403bd0
Avoid crashing when we get memory pressure events with OffscreenCanvas. r=jgilbert

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2cb4a2403bd0