Closed Bug 1746248 Opened 1 year ago Closed 1 year ago

Add support for mix-blend-mode keyword plus-lighter (Compositing 2)

Categories

(Core :: Web Painting, task, P2)

task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: dholbert, Assigned: emilio)

Details

Attachments

(3 files)

The CSSWG just resolved in https://github.com/w3c/fxtf-drafts/issues/445 to add plus-darker and plus-lighter keywords to compositing level 2.

This will presumably end up as spec text in https://drafts.fxtf.org/compositing-2/#ltblendmodegt at some point soon, with more detail. For now, the details we have are in the issues/minutes: https://github.com/w3c/fxtf-drafts/issues/445#issuecomment-995087612

--> Filing this bug to be sure we've got the change tracked.

The severity field is not set for this bug.
:miko, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mikokm)
Severity: -- → S3
Type: defect → task
Flags: needinfo?(mikokm)
Priority: -- → P2

The spec change landed, as have tests.

https://github.com/w3c/fxtf-drafts/pull/444
https://github.com/web-platform-tests/wpt/pull/31757

This is only for plus-lighter, not plus-darker. plus-darker doesn't seem to make any sense https://github.com/w3c/fxtf-drafts/issues/447.

Skia already supports this blend mode as SkBlendMode::kPlus, so hopefully implementation will be easy. It might even be a good first issue. https://api.skia.org/SkBlendMode_8h.html#ad96d76accb8ff5f3eafa29b91f7a25f0a29b0e29ca1242b047fdfcff449369c23

Summary: Add support for mix-blend-mode keywords plus-lighter and plus-darker (Compositing 2) → Add support for mix-blend-mode keyword plus-lighter (Compositing 2)
Assignee: nobody → emilio
Attachment #9262555 - Attachment description: WIP: Bug 1746248 - Implement mix-blend-mode plus-lighter. r=gw → Bug 1746248 - Style system and plumbing for mix-blend-mode: plus-lighter. r=jrmuizel
Status: NEW → ASSIGNED
Attachment #9262561 - Attachment description: Bug 1746248 - Implement mix-blend-mode: plus-lighter in WebRender. r=gw → Bug 1746248 - Implement mix-blend-mode: plus-lighter in WebRender. r=gw,lsalzman

These shouldn't be needed since bug 1691859.

Depends on D137954

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4d4cbdd2bea
Style system and plumbing for mix-blend-mode: plus-lighter. r=jrmuizel,layout-reviewers,boris
https://hg.mozilla.org/integration/autoland/rev/55c6d1a20979
Implement mix-blend-mode: plus-lighter in WebRender. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/21e3a3185ff9
Remove dead mix-blend-mode shader code. r=lsalzman
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32763 for changes under testing/web-platform/tests

Thanks for updating that test, and sorry I missed it when adding tests for this.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.