1746248 - Add support for mix-blend-mode keyword plus-lighter (Compositing 2)

Status: RESOLVED FIXED

(Core :: Web Painting, task, P2)

Description

[Daniel Holbert [:dholbert]]

The CSSWG just resolved in https://github.com/w3c/fxtf-drafts/issues/445 to add plus-darker and plus-lighter keywords to compositing level 2.

This will presumably end up as spec text in https://drafts.fxtf.org/compositing-2/#ltblendmodegt at some point soon, with more detail. For now, the details we have are in the issues/minutes: https://github.com/w3c/fxtf-drafts/issues/445#issuecomment-995087612

--> Filing this bug to be sure we've got the change tracked.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:miko, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Jake Archibald]

The spec change landed, as have tests.

https://github.com/w3c/fxtf-drafts/pull/444
https://github.com/web-platform-tests/wpt/pull/31757

This is only for plus-lighter, not plus-darker. plus-darker doesn't seem to make any sense https://github.com/w3c/fxtf-drafts/issues/447.

Skia already supports this blend mode as SkBlendMode::kPlus, so hopefully implementation will be easy. It might even be a good first issue. https://api.skia.org/SkBlendMode_8h.html#ad96d76accb8ff5f3eafa29b91f7a25f0a29b0e29ca1242b047fdfcff449369c23

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1746248 - Style system and plumbing for mix-blend-mode: plus-lighter. r=jrmuizel

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1746248 - Implement mix-blend-mode: plus-lighter in WebRender. r=gw,lsalzman

https://drafts.fxtf.org/compositing-2/#porterduffcompositingoperators_plus_lighter

Depends on D137951

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1746248 - Remove dead mix-blend-mode shader code. r=lsalzman,gw

These shouldn't be needed since bug 1691859.

Depends on D137954

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d4cbdd2bea
Style system and plumbing for mix-blend-mode: plus-lighter. r=jrmuizel,layout-reviewers,boris
https://hg.mozilla.org/integration/autoland/rev/55c6d1a20979
Implement mix-blend-mode: plus-lighter in WebRender. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/21e3a3185ff9
Remove dead mix-blend-mode shader code. r=lsalzman

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32763 for changes under testing/web-platform/tests

Comment 8

[Jake Archibald]

Thanks for updating that test, and sorry I missed it when adding tests for this.

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e4d4cbdd2bea
https://hg.mozilla.org/mozilla-central/rev/55c6d1a20979
https://hg.mozilla.org/mozilla-central/rev/21e3a3185ff9

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot