1746370 - Pass SOURCE resource down to newGeneratedSources

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

I was actually wrong in bug 1745795.
The objects passed to newGeneratedSources aren't SourceFront.
Instead they are SOURCE resources, which ends up also being SourceActor's form.

It would be nice to get this right, and while we are at doing this, finaly get rid of the intermediate objects between crafted between firefox.js and newSources.js. Instead we can pass down the SOURCE resources as-is.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1746370 - [devtools] Simplify SourceQueue as it only handles original sources.

SourceQueue used to throttle both generated and original sources.
But since we migrated to ResourceCommand, and it comes with a builtin throttling,
we only use SourceQueue for original sources.

So we can acknowledge that and simplify this a bit.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1746370 - [devtools] Remove stringToSourceActorId as this was a workaround for flow.

This was only useful when flow was used.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1746370 - [devtools] Pass SOURCE resources down to newGeneratedSources.

Actually I was wrong in bug 1745795.
This wasn't SourceFront but SOURCE resources, which are SourceActor's form and not a Front.

Let's make it clear and simplify the code some more.
Also stop calling makeSourceId from create.js
as we already have the reducer's source id via the reducer's source-actor's source attribute.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf1d3a34a897
[devtools] Simplify SourceQueue as it only handles original sources. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ae93faa865c7
[devtools] Remove stringToSourceActorId as this was a workaround for flow. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e28f3304f362
[devtools] Pass SOURCE resources down to newGeneratedSources. r=nchevobbe

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/cf1d3a34a897
https://hg.mozilla.org/mozilla-central/rev/ae93faa865c7
https://hg.mozilla.org/mozilla-central/rev/e28f3304f362