1746382 - Remove static string lookup from atomization

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

partially followup bug for bug 1722962.

once bug 1745664 gets fixed, we have the same well-know atoms and static strings between frontend and VM, and that means we don't have to perform static string lookup during instantiation.

Comment 1

[Tooru Fujisawa [:arai]]

bugs depending on bug 1746572 are going to cleanup AllowGC handling around string allocation, and this should be done after that,
given this bug is going to add more specialization.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1746382 - Remove static string lookup from stencil instantiation. r?tcampbell!

Depends on D133621

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0aa76da755c
Remove static string lookup from stencil instantiation. r=tcampbell

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing multiple failures. CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/5f0294c305465f40899be2e0fcc508de594c5b45

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=7269c2e3b6f8fffd62c5c30bb7a0b72739d68e81&selectedTaskRun=M-hOPyTtQ4qyRpr4g40jOw.0

Link to failure log:
https://treeherder.mozilla.org/logviewer?job_id=364446492&repo=autoland&lineNumber=97820
https://treeherder.mozilla.org/logviewer?job_id=364446456&repo=autoland&lineNumber=89217
https://treeherder.mozilla.org/logviewer?job_id=364446482&repo=autoland&lineNumber=81388
https://treeherder.mozilla.org/logviewer?job_id=364448493&repo=autoland&lineNumber=1513
https://treeherder.mozilla.org/logviewer?job_id=364448500&repo=autoland&lineNumber=804
https://treeherder.mozilla.org/logviewer?job_id=364448486&repo=autoland&lineNumber=1677
https://treeherder.mozilla.org/logviewer?job_id=364448542&repo=autoland&lineNumber=1711
https://treeherder.mozilla.org/logviewer?job_id=364448521&repo=autoland&lineNumber=1697

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

We also encounter the issue bellow. Can you take a look also at this ?

https://treeherder.mozilla.org/jobs?repo=autoland&duplicate_jobs=visible&resultStatus=testfailed%2Cbusted%2Cexception&revision=7269c2e3b6f8fffd62c5c30bb7a0b72739d68e81&searchStr=Android%2C7.0%2Cx86&selectedTaskRun=Y9r0qkV_Rh-zll-0bCipMw.5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6b63e945046
Remove static string lookup from stencil instantiation. r=tcampbell

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f6b63e945046