Closed Bug 1746944 Opened 2 years ago Closed 2 years ago

Setting ui.swipeAnimationEnabled to 0 breaks swipe navigation

Categories

(Firefox :: General, defect)

defect

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file)

A problem here in gHistorySwipeAnimation.init. The isLTR variable isn't set if the pref is false, thus swipe nav's direction gets confused.

Component: Panning and Zooming → General
Product: Core → Firefox

gHistorySwipeAnimation.isLTR is used to tell the navigation direction [1],
it needs to be independent from the fact whether the swipe animation is
supported or not.

[1] https://searchfox.org/mozilla-central/rev/125116c312b0a9c438d44e16011b116950caf17e/browser/base/content/browser-gestureSupport.js#240

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28d7f0c75414
Initialize gHistorySwipeAnimation.isLTR in HSA_init even if ui.swipeAnimationEnabled is disabled. r=spohl
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: