Trackpad gestures (swipe left/right to navigate history) not working on Windows
Categories
(Core :: Panning and Zooming, defect, P2)
Tracking
()
People
(Reporter: enrico.schroeder, Assigned: hiro, NeedInfo)
References
Details
(Whiteboard: tpi:+, widget-next)
Attachments
(13 files, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Comment 2•8 years ago
|
||
Reporter | ||
Comment 3•8 years ago
|
||
Comment 4•8 years ago
|
||
Reporter | ||
Comment 5•8 years ago
|
||
Comment 6•8 years ago
|
||
Updated•8 years ago
|
Updated•6 years ago
|
Comment 8•5 years ago
|
||
Just to confirm same happens for me, Firefox 67, Windows 10, Precision trackpad. To follow up on the last request - still did not work with browser.tabs.remote.autostart set to false, or layers.async-pan-zoom.enabled set to false. Pinch zoom does work, two-finger scroll does work, only two finger left/right does not navigate. Tried turning off two-finger scrolling in system settings, and that did indeed stop two-finger scrolling but no other change.
Comment 9•5 years ago
|
||
Same for me, one finger swipe left/right does not work for me on FF 71, either on Gentoo Linux or Windows 10. It is interesting that same gesture works well on Google Chrome/Chromium. It seems that swipe right or left always works as scrolling left or right but behaviour does not respond to the commands set in about:config which are by default back and forward. I doubt that this is system-wide problem since the behavior is same across operating systems and there is no problem with Chrome, and Firefox always respond to swipe left and right as scroll event.
Comment 10•5 years ago
|
||
Confirming the Same Behavior
In Firefox:
- Two finger scroll up and down works correctly
- Two finger scroll horizontally works correctly when a page is zoomed
- Pinch to zoom works correctly both with apz.allow_zooming enabled or disabled
- This setting enables Chrome style smooth zooming rather than the Firefox native reflow zooming
In Chrome/Edge:
All above gestures working + two finger swipe for forward and back working
Experimentation:
As horizontal scrolling works correctly via the track pad I tried to determine whether the issue is from the Browser:BackOrBackDuplicate command. To do this I change the following settings in about:config
Old Values:
browser.gesture.swipe.left Browser:BackOrBackDuplicate
browser.gesture.swipe.right Browser:ForwardOrForwardDuplicate
New Values:
browser.gesture.swipe.left cmd_scrollTop
browser.gesture.swipe.right cmd_scrollBottom
This resulted in no change in behavior. The swipe left and swipe right gestures did not trigger the vertical scroll commands as I hoped. This makes me think that Browser:BackOrBackDuplicate and Browser:ForwardOrForwardDuplicate are working properly, and that Firefox simply isn't registering the left and right swipe gestures
Firefox: Version 73.0.1 (64-bit)
OS: Windows 10 Version 10.0.1863 Build 18363
Hardware: Microsoft Surface Book 2, i7-8650U, 8GB RAM, GTX 1050
TouchPad: Intel Precision Touch Device Driver Version 1.2.0.100
Comment 11•5 years ago
|
||
First bug reporting for me, i have the same problem. I check the value :
browser.gesture.swipe.left : Browser:BackOrBackDuplicate
browser.gesture.swipe.right : Browser:ForwardOrForwardDuplicat
All looks good.
But ! if i use SwipeToNavigate by top1, it work.
https://addons.mozilla.org/fr/firefox/addon/swipetonavigate/?src=search
If i can give you more information, please tell me.
Thanks all
Comment hidden (me-too) |
Comment hidden (me-too) |
Comment 14•4 years ago
|
||
The browser.gesture.swipe.* prefs are only used in the browser-gestureSupport.js code, in particular in response to these internal events that are dispatched from the per-platform Gecko widget layer. However, as far as I can tell, the Windows code does not, and has never, dispatched swipe events. So if horizontal two-finger swipe used to do forward/back, I'm pretty confident it wasn't due to Firefox handling the swipe, but the trackpad driver converting that gesture in some key combination that Firefox understands. If this used to work before but doesn't work now, it is likely due to some change in Firefox that caused the trackpad driver to stop doing this, or that otherwise breaks some assumptions. The most useful thing to do would be to get a regression range using mozregression
on Firefox Nightly builds.
Comment hidden (advocacy) |
Comment 16•4 years ago
|
||
This is on our shortlist of features we'd really like to implement.
There have been discussions of this being one of a set of APZ features / improvements worked on as part of the Firefox Proton refresh, but even if it doesn't make that cut, it's likely to be a high-priority follow-up.
Comment 17•3 years ago
|
||
bump. this is a deal-breaking UX feature, especially for users coming from chromium-baesd browsers
Comment 18•3 years ago
|
||
+1, gesture based navigation should be core functionality
Comment 19•3 years ago
|
||
+1, the browser feels dated without a this working on both touchpad and touchscreen.
Comment 20•3 years ago
|
||
+1 , this is incredibly important to me and other people I have tried to convince to use Firefox
Comment 21•3 years ago
|
||
+1, I created an account just to write this comment, so hopefully that shows you something. About 2 years ago I moved back over to Firefox and it's been working great on my Windows desktop and Mac laptop, but since my (very) recent switch to a Windows-based laptop this is a dealbreaker in terms of UX for me, as this works fine on Mac (so, I'm used to it) and all other major browsers on Windows implement this feature, so there really can't be an argument for Firefox not to have it. I'd hate to switch back to Chrome on all my devices, but it's really THAT annoying not to have this feature.
Comment 22•3 years ago
|
||
+1 for me too. Its really strange but on one Windows laptop three swipe gesture does go back/forward but not on this laptop. It would be great if it was just 2 finger gesture as standard (and works).
Comment 23•3 years ago
|
||
(In reply to Rez from comment #22)
+1 for me too. Its really strange but on one Windows laptop three swipe gesture does go back/forward but not on this laptop. It would be great if it was just 2 finger gesture as standard (and works).
The 3 finger swipe can be configured via the Windows Touchpad settings, so one of your laptops will have that configuration, the other one won't. Also see this thread on Reddit, where you can find instructions on how to configure this in more detail: https://www.reddit.com/r/firefox/comments/m1y1ps/windows_10_touchpad_gestures_two_finger_swipe_to/
Nonetheless, I use 2 finger swipe for a reason, so 3 finger swipe configuration isn't going to cut it for me.
Comment 24•3 years ago
|
||
This is totally absurd. Just tried switching back to Firefox after trying Quantum when it came out and having to leave (for a multitude of reasons); not having this is a real deal-breaker, however mundane it may seem. So many people are used to this gesture and it ruins the experience to have to press ALT + Left or move the mouse to the back button, especially when trying to research and/or just navigate quickly. I genuinely save so much time doing the two-finger swipe, even though Firefox seems faster and lighter weight, I can move around so much faster in edge or chrome I can only use Firefox when I'm not trying to do something quickly, because it does really matter that much. In Firefox I have to go from what I do in supporting browsers which is moving on the trackpad with one finger then adding another to quickly go up, down, or to navigate, to either go to the top corner to click on things while scrolling then move to the page content to scroll then go back again, or use the keyboard shortcut which is more intrusive than just typing because the shortcut keys are right where my palm is. This is such a simple easy mechanic that so many people appreciate it is an serious understatement to say it's gigantic miscalculation here. This is infuriating. I, too, like other people have had to make an account just to say this here. This is seriously dumb. This has been broken for years.
Comment 25•3 years ago
|
||
I've also been trying to migrate my primary browser usage back to Firefox, but this is very important missing UX feature IMHO. I'm only leaving a comment because I don't see a way to to vote for issues, and this is the next best thing.
Comment 26•3 years ago
|
||
Folks, we hear you. This feature is on our (Panning and Zooming team) roadmap, and it's very close to the top of it. The only thing ahead of it are our very highest priority stability fixes. We're working hard to get through those and looking forward to starting development on this in the next month or so.
Comment 27•3 years ago
|
||
Moving component to Panning and Zooming to reflect that, while this will involve changes to Widget code, our team will be working on this feature.
Comment 28•3 years ago
|
||
That's great, thank you for the confirmation Botond :)
Assignee | ||
Comment 29•3 years ago
|
||
Oops I've been CC-ed here but I did forget this bug. :/ For browser navigation by swipe gestures on Windows, I've started working on it in bu 1564022, FYI.
Updated•3 years ago
|
Comment 33•3 years ago
|
||
Martin, I remember from an earlier discussion that when porting this feature (currently supported on Mac) to Windows, we may want to give the UX design team an opportunity to tweak the assets for the visual feedback arrows that appear when you perform swipe-to-navigate, to be consistent with the look of the platform, if they wish.
As we've now started engineering work on this feature, I wanted to flag you to see if we should run this by them / get it on their radar.
Assignee | ||
Comment 34•3 years ago
|
||
It's not used at all.
Assignee | ||
Comment 35•3 years ago
|
||
Depends on D134358
Assignee | ||
Comment 36•3 years ago
|
||
Depends on D134359
Assignee | ||
Comment 37•3 years ago
|
||
Depends on D134360
Assignee | ||
Comment 38•3 years ago
|
||
Depends on D134361
Assignee | ||
Comment 39•3 years ago
|
||
Depends on D134362
Assignee | ||
Comment 40•3 years ago
|
||
Depends on D134363
Assignee | ||
Comment 41•3 years ago
|
||
Depends on D134364
Assignee | ||
Comment 42•3 years ago
|
||
It's not used at all.
Depends on D134365
Assignee | ||
Comment 43•3 years ago
|
||
Depends on D134366
Assignee | ||
Comment 44•3 years ago
|
||
The PanGestureInput
, the argument of the new function named CanTriggerSwipe,
is generated by theEvent
, mPanDisplacement
so both inequalities are equivalent.
Depends on D134367
Assignee | ||
Comment 45•3 years ago
|
||
Depends on D134368
Assignee | ||
Comment 46•3 years ago
|
||
I uploaded all patches to make the swipe-to-nav work on Windows. I haven't yet written tests.
Assignee | ||
Comment 47•3 years ago
•
|
||
I found there's a test (which I wrote before, but I can't recall the detail), but it's for a specific case and only for Mac, we need to make it work on other platforms and add a general case.
Assignee | ||
Comment 48•3 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #47)
I found there's a test (which I wrote before, but I can't recall the detail), but it's for a specific case and only for Mac, we need to make it work on other platforms and add a general case.
It turned out that the browser_test_swipe_gesture.js test would be sufficient, it includes normal navigations.
Assignee | ||
Comment 49•3 years ago
|
||
There's a race condition where the page navigation caused by swipe gestures has
already stopped when the promise for the pan gestures was resolved.
Depends on D134369
Assignee | ||
Comment 50•3 years ago
|
||
Depends on D134638
Updated•3 years ago
|
Comment 51•3 years ago
|
||
(sorry for the late response)
I will double-check with the team, but it's OK to continue with the assets we already have. We can file another bug in case we want to optimize the arrows.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 52•3 years ago
|
||
Comment 53•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a6246c744779
https://hg.mozilla.org/mozilla-central/rev/c057fa40caf7
https://hg.mozilla.org/mozilla-central/rev/28a5cb06ece8
https://hg.mozilla.org/mozilla-central/rev/e96d9b6dc70c
https://hg.mozilla.org/mozilla-central/rev/70520fc1660e
https://hg.mozilla.org/mozilla-central/rev/5f838131ae32
https://hg.mozilla.org/mozilla-central/rev/1c6284530243
https://hg.mozilla.org/mozilla-central/rev/acefc474e960
https://hg.mozilla.org/mozilla-central/rev/67859633bb44
https://hg.mozilla.org/mozilla-central/rev/72c816ff1334
https://hg.mozilla.org/mozilla-central/rev/c4d2d0f6137e
https://hg.mozilla.org/mozilla-central/rev/d1a04dde5a73
https://hg.mozilla.org/mozilla-central/rev/9ff648d32b4d
Comment 54•3 years ago
|
||
Apologies for bumping a closed issue, but is this fix supposed to be available in the new Firefox 97 release? I have installed the update but touchpad gestures (i.e. swiping left/right) still do not work for me. Is it something I need to enable?
Assignee | ||
Comment 55•3 years ago
•
|
||
No, it was disabled on Firefox 97 unfortunately due to bug 1751124. You can still use the feature by setting widget.disable-swipe-tracker to false in about:config.
EDITED: s/widget.disable-swipe-tracker to true/widget.disable-swipe-tracker to false/
Comment 56•3 years ago
|
||
So when can we expect this feature to be enabled by default? Which issue is blocking it? The aforementioned bug seems to be closed as well.
Assignee | ||
Comment 57•3 years ago
|
||
(In reply to john from comment #56)
So when can we expect this feature to be enabled by default? Which issue is blocking it? The aforementioned bug seems to be closed as well.
We are planing to enable it on Firefox 98. But it depends on bug 1753146.
John and enfo, if you guys are Windows user, would you mind trying a build in bug 1753146 comment 1 to see whether those default pref values are too sensitive and giving us some feedback with tweaking the pref values? It would be quite helpful for us. Thanks!
Assignee | ||
Comment 58•3 years ago
|
||
Hello guys, the build in bug 1753146 comment 1 has a big mistake. A new proper build is coming in bug 1753146 comment 10. Thanks!
Comment 59•3 years ago
|
||
Not sure if you want the feedback here or in bug 1753146, but I've installed the latest build now and can confirm that swiping to navigate is working. In regards to sensitivity (i.e. how far I have to swipe for the action to be registered/identified), it feels pretty much as expected to me (comparing to Chrome), but one big difference is the delay between the swipe motion being registered and actually being taken to the next/previous page.
In Chrome, the time from my swipe being registered/identified as "go to previous page" (I assume by crossing some distance threshold) to being taken to the actual page is near instant after I release my fingers from the touchpad.
In Firefox, I do the same swiping motion, the black arrow appears on the side of the window, and I can then let go of my touchpad for around 2-3 seconds before I am taken to the previous page. In other words, there seems to be some kind of lag after the swipe where nothing happens.
I hope this makes sense and is useful feedback.
Assignee | ||
Comment 60•3 years ago
|
||
Thank you for the feedback. Indeed I saw the lag locally. I tried the build on my Windows laptop, then using the build forced me to create a new profile, then I saw the lag a couple of times. But after some back and forth navigation I no longer see the lag. So perhaps the browser did something for the new profile on background?
Hmm no, I saw the lag again, but can't produce now.
Assignee | ||
Comment 61•3 years ago
|
||
Okay I found a way to see the lag. The lag happens when I do strongly fling the gesture. And now I saw on Windows a PANGESTURE_END after pan momentum events... That's totally different from the behavior on Mac IIRC.
Assignee | ||
Comment 62•3 years ago
|
||
enfo, your feedback realized me bug 1754674. You saved a lot of my time. Thank you!
Comment 63•3 years ago
|
||
Updating flags because this was disabled in bug 1751124.
Updated•3 years ago
|
Updated•3 years ago
|
Comment 64•3 years ago
|
||
(In reply to john from comment #56)
So when can we expect this feature to be enabled by default? Which issue is blocking it? The aforementioned bug seems to be closed as well.
I've filed bug 1758196 to track enabling the feature by default on the release channel. You can follow that bug for updates.
Updated•3 years ago
|
Comment 65•3 years ago
|
||
This is working as expected on RC 99, after chaining the pref widget.disable-swipe-tracker
to false. Tested with Win 10 x64.
Description
•