1747059 - [Shadow Realms] Expose Web APIs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Ref https://github.com/tc39/proposal-shadowrealm/issues/331

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1747059 - Add GetRealmObjectPrototypeHandle r?jandem

This is required to interact with Gecko's ProtoHandleGetter type.

I wish it wasn't, but trying to fix the codegen to just root things properly
ate too much of my time.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1747059 - Gecko support for ShadowRealms r?peterv!,smaug!

Depends on D146348

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1747059 - Ensure ShadowRealmsGlobalScope has an ordinary object prototype. r?edgar

(Patch largely written by peterv; I just made some compilation tweaks)

Depends on D146349

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: WIP: Bug 1747059 - Enable running shadow realm WPT tests

Depends on D146350

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1747059 - Use AllowIfExists in nsJSUtils::IsScriptable r?smaug

Depends on D146238

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1747059 - Add ShadowRealm module loader support to ScriptLoader r?yulia

Depends on D147464

Comment 7

[Phabricator Automation]

Comment on attachment 9276517 [details]
WIP: Bug 1747059 - Enable running shadow realm WPT tests

Revision D146351 was moved to bug 1771524. Setting attachment 9276517 [details] to obsolete.

Comment 8

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1747059 - Correctly select microtask queue when enquing a job in a ShadowRealm in a worker. r?smaug

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e06192e664fd
Use AllowIfExists in nsJSUtils::IsScriptable r=smaug
https://hg.mozilla.org/integration/autoland/rev/8115813e77a5
Add ShadowRealm module loader support to ScriptLoader r=yulia
https://hg.mozilla.org/integration/autoland/rev/aad38abc7139
Add GetRealmObjectPrototypeHandle r=jonco
https://hg.mozilla.org/integration/autoland/rev/f7b049ef3b8c
Gecko support for ShadowRealms r=peterv,smaug
https://hg.mozilla.org/integration/autoland/rev/40a257fb4788
Ensure ShadowRealmsGlobalScope has an ordinary object prototype. r=edgar
https://hg.mozilla.org/integration/autoland/rev/ed7aad37f2cf
Correctly select microtask queue when enquing a job in a ShadowRealm in a worker. r=smaug

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1767525 for causing hazard failures on ShadowRealmGlobalScope.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/15a26c0f488ed2cf99665ef13eb186f68e6fc386
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=DQ2PFCLDSKGojdwjwAKCWg.0&revision=ed7aad37f2cfc0c1d693be70b2d9e148ecad8667
• failure log: https://treeherder.mozilla.org/logviewer?job_id=382685145&repo=autoland&lineNumber=98447

Function '_ZN7mozilla3dom20NewShadowRealmGlobalEP9JSContextRN2JS12RealmOptionsEP12JSPrincipalsNS3_6HandleIP8JSObjectEE$JSObject* mozilla::dom::NewShadowRealmGlobal(JSContext*, JS::RealmOptions*, JSPrincipals*, JS::Handle<JSObject*>)' has unrooted '<returnvalue>' of type 'JSObject*' live across GC call 'nsCOMPtr<T>::~nsCOMPtr() [with T = nsIGlobalObject] [[complete_dtor]]' at dom/script/ShadowRealmGlobalScope.cpp:53

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7216dbfe77c
Use AllowIfExists in nsJSUtils::IsScriptable r=smaug
https://hg.mozilla.org/integration/autoland/rev/e5989730d306
Add ShadowRealm module loader support to ScriptLoader r=yulia
https://hg.mozilla.org/integration/autoland/rev/0bff2200929e
Add GetRealmObjectPrototypeHandle r=jonco
https://hg.mozilla.org/integration/autoland/rev/0a045042fc65
Gecko support for ShadowRealms r=peterv,smaug
https://hg.mozilla.org/integration/autoland/rev/21466a3860e7
Ensure ShadowRealmsGlobalScope has an ordinary object prototype. r=edgar
https://hg.mozilla.org/integration/autoland/rev/d78c028ad053
Correctly select microtask queue when enquing a job in a ShadowRealm in a worker. r=smaug

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d7216dbfe77c
https://hg.mozilla.org/mozilla-central/rev/e5989730d306
https://hg.mozilla.org/mozilla-central/rev/0bff2200929e
https://hg.mozilla.org/mozilla-central/rev/0a045042fc65
https://hg.mozilla.org/mozilla-central/rev/21466a3860e7
https://hg.mozilla.org/mozilla-central/rev/d78c028ad053