1747138 - Breakdown CPU and GPU time telemetry by process type

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, task)

Description

[Florian Quèze [:florian]]

Bug 1736040 added telemetry for the total CPU time used. It would be useful to have a breakdown of this total by process type.

We are also interested in knowning how much CPU time is spent while the user is active or inactive, and how much time is spent in content processes for foreground or background tabs.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1747138 - Breakdown CPU and GPU time by process type,

Comment 2

[Florian Quèze [:florian]]

Attachment: data-collection-review request

Comment 3

[Chris H-C :chutten]

Comment on attachment 9261268 [details]
data-collection-review request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Florian Quèze is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd96e020a609
Breakdown CPU and GPU time by process type, r=chutten,gsvelto

Comment 5

[Sandor Molnar[:smolnar]]

Backed out changeset cd96e020a609 (bug 1747138) for causing bc failures in browser_telemetry_video_hardware_decoding_support

Backout link: https://hg.mozilla.org/integration/autoland/rev/546c9a60b2593b20afe0a40cdb101fc5b138e3f2

Push with failures

Failure log

 INFO - Buffered messages finished
[task 2022-02-03T17:59:36.663Z] 17:59:36     INFO - TEST-UNEXPECTED-FAIL | dom/media/test/browser/browser_telemetry_video_hardware_decoding_support.js | Did not record scalar for small-shot.ogg - 
[task 2022-02-03T17:59:36.663Z] 17:59:36     INFO - Stack trace:

Comment 6

[Florian Quèze [:florian]]

Oops, somehow this wasn't visible in my try run, sorry.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b24313d474bb
Breakdown CPU and GPU time by process type, r=chutten,gsvelto

Comment 8

[Marian-Vasile Laza]

Hi, after this push, Bug 1709184 started to appear more frequently: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&searchStr=windows%2C10%2Cx86%2C2004%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-windows10-32-2004-qr%2Fdebug-mochitest-plain-fis-e10s%2C3&fromchange=1beef8eefd61899d01707cf2b6a9bf9e43642ad5&tochange=27d0103a7155d760cb2eda41bfb4c2b9bc6bbd1a&selectedTaskRun=Z1VmWFSgSN6j2YdNZb6A7w.0

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b24313d474bb

Comment 10

[Florian Quèze [:florian]]

(In reply to Marian-Vasile Laza from comment #8)

Hi, after this push, Bug 1709184 started to appear more frequently

Thanks, I opened bug 1753598 to investigate, as even though the assertion is the same, the stack is different and points to https://searchfox.org/mozilla-central/rev/bb14d901ac16633801b7f4adaa4fb104e6f072e4/toolkit/components/glean/ipc/Support.cpp#21,25