1747293 - About dialog got wider

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Itiel]

Attachment: About dialog in the current Nightly

See attached.
The regression range should be:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=668eb55faa54c6ae467e08205a6498603734e254&tochange=b3e23657859cb4ca2cfb5db9d57188e584f0293e
Bug 1746517 should be the prime suspect, but reverting it (and the other 2 related patches) locally doesn't fix it.

Comment 1

[Itiel]

Attachment: How wide the about dialog should be

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1747293 - Strip hash and search parameter from about dialog manual update url text to prevent the window from widening due to text length. r=bhearsum

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1746517

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Since today is merge day for Firefox 97, please make sure to request beta uplift for this patch.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/023cef062284
Strip hash and search parameter from about dialog manual update url text to prevent the window from widening due to text length. r=bhearsum,application-update-reviewers,bytesized

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/023cef062284

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 11

[Nick Rishel [:nrishel]]

Comment on attachment 9256601 [details]
Bug 1747293 - Strip hash and search parameter from about dialog manual update url text to prevent the window from widening due to text length. r=bhearsum

Beta/Release Uplift Approval Request

• User impact if declined: Firefox About Dialog appears subtly incorrectly laid out, unprofessional appearance.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only changes the way url text is displayed in About Dialog UI.
• String changes made/needed: Display URL change only

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9256601 [details]
Bug 1747293 - Strip hash and search parameter from about dialog manual update url text to prevent the window from widening due to text length. r=bhearsum

Approved for 97.0b3.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e49509fe12c

Comment 14

[Monica Chiorean]

I was able to reproduce the issue on Win10 using build 97.0a1 (2021-12-22) on EN.
Verified as fixed on Win10, Ubuntu 20.4 and Mac 10.13 using builds: Beta 97.0b3(20220113185849) and NB 98.0a1 (2022-01-14).

Comment 15

[Nick Rishel [:nrishel]]

Comment on attachment 9256601 [details]
Bug 1747293 - Strip hash and search parameter from about dialog manual update url text to prevent the window from widening due to text length. r=bhearsum

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needs to land with esr only patch https://bugzilla.mozilla.org/show_bug.cgi?id=1592731
• User impact if declined: If other patch lands, About page will appear poorly formatted in ESR.
• Fix Landed on Version: 97
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Well defined, verified by qa.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9256601 [details]
Bug 1747293 - Strip hash and search parameter from about dialog manual update url text to prevent the window from widening due to text length. r=bhearsum

Approved for 91.6esr.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/9f7b0e1a8b7e

Comment 18

[Monica Chiorean]

I checked on Win10 and Ubuntu20.4 and about dialog is wider on 91.6.0esr than the about dialog on 91.5.1esr.
Is this expected?

Note: on latest NB 98.0a1(2022-02-01) the about dialog is smaller than 97.0a1 (2021-12-22) on EN.

Comment 19

[Nick Rishel [:nrishel]]

To my knowledge the about dialog should not have widened. The source of this bug was that the manual page url had been significantly extended because the hyperlink text included new query parameters which was stretching the window (even when the text was hidden). The fix was to strip the query parameters from visible text.

However, the manual update url for esr was updated to point to the esr (enterprise) url, and that url is longer than the equivalent url for stable by a few characters. It's feasible this widened the dialog. The relevant bug to fix that is https://bugzilla.mozilla.org/show_bug.cgi?id=1747675