1747403 - Perma toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature devtools.webconsole.input.context should match runtime value. - fa when Gecko 97 merges to Beta on 2022-01-10

Status: VERIFIED FIXED

(Toolkit :: FeatureGate, defect)

Description

[Norisz Fay [:noriszfay]]

Central-as-beta simulation
How to run these simulations

Failure log:

[task 2021-12-23T12:50:28.153Z] 12:50:28     INFO -  TEST-START | toolkit/components/featuregates/test/unit/test_FeatureGate.js
[task 2021-12-23T12:50:28.418Z] 12:50:28  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | xpcshell return code: 0
[task 2021-12-23T12:50:28.418Z] 12:50:28     INFO -  TEST-INFO took 264ms
[task 2021-12-23T12:50:28.418Z] 12:50:28     INFO -  >>>>>>>
[task 2021-12-23T12:50:28.419Z] 12:50:28     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-12-23T12:50:28.419Z] 12:50:28     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-12-23T12:50:28.419Z] 12:50:28     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-12-23T12:50:28.419Z] 12:50:28     INFO -  running event loop
[task 2021-12-23T12:50:28.419Z] 12:50:28     INFO -  toolkit/components/featuregates/test/unit/test_FeatureGate.js | Starting testReadAll
[task 2021-12-23T12:50:28.419Z] 12:50:28     INFO -  (xpcshell/head.js) | test testReadAll pending (2)
[task 2021-12-23T12:50:28.420Z] 12:50:28     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2021-12-23T12:50:28.420Z] 12:50:28     INFO -  TEST-PASS | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testReadAll - [testReadAll : 83] Features are returned in order of definition - "test-featureA" == "test-featureA"
<...>
[task 2021-12-23T12:50:28.453Z] 12:50:28     INFO -  TEST-PASS | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature devtools.inspector.compatibility.enabled should match runtime value. - false == false
[task 2021-12-23T12:50:28.453Z] 12:50:28  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature devtools.webconsole.input.context should match runtime value. - false == true
[task 2021-12-23T12:50:28.454Z] 12:50:28     INFO -  /opt/worker/tasks/task_164026289053942/build/tests/xpcshell/tests/toolkit/components/featuregates/test/unit/test_FeatureGate.js:testAllDefaultsMatchSettings:440
[task 2021-12-23T12:50:28.454Z] 12:50:28     INFO -  /opt/worker/tasks/task_164026289053942/build/tests/xpcshell/head.js:_do_main:240
[task 2021-12-23T12:50:28.454Z] 12:50:28     INFO -  /opt/worker/tasks/task_164026289053942/build/tests/xpcshell/head.js:_execute_test:604
[task 2021-12-23T12:50:28.454Z] 12:50:28     INFO -  -e:null:1
[task 2021-12-23T12:50:28.454Z] 12:50:28     INFO -  exiting test
[task 2021-12-23T12:50:28.454Z] 12:50:28     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2021-12-23T12:50:28.454Z] 12:50:28     INFO -  _abort_failed_test@/opt/worker/tasks/task_164026289053942/build/tests/xpcshell/head.js:875:20
[task 2021-12-23T12:50:28.455Z] 12:50:28     INFO -  do_report_result@/opt/worker/tasks/task_164026289053942/build/tests/xpcshell/head.js:976:5
[task 2021-12-23T12:50:28.455Z] 12:50:28     INFO -  Assert<@/opt/worker/tasks/task_164026289053942/build/tests/xpcshell/head.js:75:21
[task 2021-12-23T12:50:28.455Z] 12:50:28     INFO -  proto.report@resource://testing-common/Assert.jsm:228:10
[task 2021-12-23T12:50:28.455Z] 12:50:28     INFO -  equal@resource://testing-common/Assert.jsm:270:8
[task 2021-12-23T12:50:28.455Z] 12:50:28     INFO -  testAllDefaultsMatchSettings@/opt/worker/tasks/task_164026289053942/build/tests/xpcshell/tests/toolkit/components/featuregates/test/unit/test_FeatureGate.js:440:12
[task 2021-12-23T12:50:28.455Z] 12:50:28     INFO -  _do_main@/opt/worker/tasks/task_164026289053942/build/tests/xpcshell/head.js:240:6
[task 2021-12-23T12:50:28.455Z] 12:50:28     INFO -  _execute_test@/opt/worker/tasks/task_164026289053942/build/tests/xpcshell/head.js:604:5
[task 2021-12-23T12:50:28.456Z] 12:50:28     INFO -  @-e:1:1
[task 2021-12-23T12:50:28.456Z] 12:50:28     INFO -  exiting test
[task 2021-12-23T12:50:28.456Z] 12:50:28     INFO -  <<<<<<<
[task 2021-12-23T12:50:28.456Z] 12:50:28     INFO -  TEST-START | toolkit/components/url-classifier/tests/unit/test_listmanager.js

Hi Niklas, this seems to be related to bug 1742826 that was previously marked as fixed, which is caused by bug 1617609 , could you take a look please? Thank you!

Comment 1

[Niklas]

[task 2021-12-23T12:50:28.453Z] 12:50:28  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 440] Feature devtools.webconsole.input.context should match runtime value. - false == true

I don't think this is caused by the samesite prefs that we flipped. (Bug 1742826 covered all off those)

Hi Nicolas, you recently flipped the devtools.webconsole.input.context pref in https://phabricator.services.mozilla.com/D134482, i think this is related to that.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1747403 - adjust devtools.webconsole.input.context default value in FeatureGate. r=nchevobbe

Bug 1731740 set devtools.webconsole.input.context to true across all branches
and the separate, expected default value in FeatureGate still needed
adjustment.

Comment 3

[Intermittent Failures Robot]

24 failures in 2286 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #30 most frequent failure this week.

Repository breakdown:

• try: 24

Platform and build breakdown:

• linux1804-64-devedition-qr: 3
  • opt: 3
• macosx1100-64-shippable-qr: 4
  • opt: 4
• macosx1015-64-devedition-qr: 4
  • opt: 4
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• windows10-64-2004-devedition-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 3
  • opt: 3
• macosx1015-64-shippable-qr: 3
  • opt: 3
• windows7-32-shippable-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1747403&startday=2021-12-20&endday=2021-12-26&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1719c0c6dd1
adjust devtools.webconsole.input.context default value in FeatureGate. r=preferences-reviewers,Gijs

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f1719c0c6dd1

Comment 6

[Iulian Moraru]

Fix verified in today's central as early beta simulation.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

err, sorry about this and thanks for taking care of it!